[asterisk-commits] jrose: branch 10 r361907 - in /branches/10: ./ apps/ configs/

[SVN commits to the Asterisk project]

Author: jrose
Date: Wed Apr 11 11:07:50 2012
New Revision: 361907

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=361907
Log:
Change default value of 'ignorebusy' on Queue members so that behavior is more like 1.8

Prior to this patch, in order to restore that behavior, a function would have
to be used on the QueueMember to make the ringinuse option do anything, which
is pretty unreasonable.

(closes issue ASTERISK-19536)
reported by: Philippe Lindheimer
Review: https://reviewboard.asterisk.org/r/1860/

Modified:
    branches/10/CHANGES
    branches/10/apps/app_queue.c
    branches/10/configs/queues.conf.sample

Modified: branches/10/CHANGES
URL: http://svnview.digium.com/svn/asterisk/branches/10/CHANGES?view=diff&rev=361907&r1=361906&r2=361907
==============================================================================
--- branches/10/CHANGES (original)
+++ branches/10/CHANGES Wed Apr 11 11:07:50 2012
@@ -23,6 +23,14 @@
  * The default verbosity for ast_verb() messages has been increased to 6. This
    should help reduce the 'doing dnsmgr_lookup for' message from spamming the
    CLI.
+
+Queue changes
+-------------
+ * Default value for 'ignorebusy' flag on queue members is now 1 instead of 0
+   to get the default behavior in line with 1.8. The only way to change this
+   flag in 10 is to use the QUEUE_MEMBER function to change ignorebusy unless
+   using realtime queue members (in which case it can be manipualted on the
+   database normally).
 
 ------------------------------------------------------------------------------
 --- Functionality changes since Asterisk 10.1.0 ------------------------------

Modified: branches/10/apps/app_queue.c
URL: http://svnview.digium.com/svn/asterisk/branches/10/apps/app_queue.c?view=diff&rev=361907&r1=361906&r2=361907
==============================================================================
--- branches/10/apps/app_queue.c (original)
+++ branches/10/apps/app_queue.c Wed Apr 11 11:07:50 2012
@@ -1621,6 +1621,7 @@
 	struct member *cur;
 	
 	if ((cur = ao2_alloc(sizeof(*cur), NULL))) {
+		cur->ignorebusy = 1;
 		cur->penalty = penalty;
 		cur->paused = paused;
 		ast_copy_string(cur->interface, interface, sizeof(cur->interface));

Modified: branches/10/configs/queues.conf.sample
URL: http://svnview.digium.com/svn/asterisk/branches/10/configs/queues.conf.sample?view=diff&rev=361907&r1=361906&r2=361907
==============================================================================
--- branches/10/configs/queues.conf.sample (original)
+++ branches/10/configs/queues.conf.sample Wed Apr 11 11:07:50 2012
@@ -68,7 +68,7 @@
 ; app_queue allows calls to members in a "Unknown" state to be treated as available
 ; setting check_state_unknown = yes will cause app_queue to query the channel driver
 ; to better determine the state this only applies to queues with ringinuse or ignorebusy
-; set appropriately. 
+; set appropriately.
 ;
 ;check_state_unknown = no
 ;
@@ -481,11 +481,10 @@
 ;
 ; If you want the queue to avoid sending calls to members whose devices are
 ; known to be 'in use' (via the channel driver supporting that device state)
-; uncomment this option. (Note: only the SIP channel driver currently is able
-; to report 'in use'.)
-;
-; A member can have the ignorebusy flag set or unset when ringinuse is set to
-; allow a per member control.
+; uncomment this option. This can be controlled on a per member basis by
+; setting 'ignorebusy' in the QUEUE_MEMBER function. (Note: only the SIP
+; channel driver currently is able to report 'in use'.) (Note: if this option
+; is set to 'no' it will override the per-member 'ignorebusy' setting.
 ;
 ; ringinuse = no
 ;