[asterisk-commits] irroot: branch irroot/distrotech-customers-1.8 r336931 - /team/irroot/distrot...

[SVN commits to the Asterisk project]

Author: irroot
Date: Tue Sep 20 03:50:26 2011
New Revision: 336931

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=336931
Log:
Add comments to the format fixup patch and log warning

Modified:
    team/irroot/distrotech-customers-1.8/main/channel.c

Modified: team/irroot/distrotech-customers-1.8/main/channel.c
URL: http://svnview.digium.com/svn/asterisk/team/irroot/distrotech-customers-1.8/main/channel.c?view=diff&rev=336931&r1=336930&r2=336931
==============================================================================
--- team/irroot/distrotech-customers-1.8/main/channel.c (original)
+++ team/irroot/distrotech-customers-1.8/main/channel.c Tue Sep 20 03:50:26 2011
@@ -4893,7 +4893,17 @@
 			apply_plc(chan, fr);
 		}
 
+		/* XXX Something is not right we are not compatible with this frame bad things can happen
+		 * problems range from no/one-way audio to unexplained line hangups as a last resort try adjust the format
+		 * ideally we do not want to do this and this indicates a deeper problem for now we log these events to
+		 * eliminate user impact and help identify the problem areas
+		 * JIRA issues related to this :-
+		 * ASTERISK-14384, ASTERISK-17502, ASTERISK-17541, ASTERISK-18063, ASTERISK-18325, ASTERISK-18422*/
 		if ((!(fr->subclass.codec & chan->nativeformats)) && (chan->writeformat != fr->subclass.codec)) {
+			char nf[512];
+			ast_log(LOG_WARNING, "Codec mismatch on channel %s setting write format to %s from %s native formats %s\n",
+				chan->name, ast_getformatname(fr->subclass.codec), ast_getformatname(chan->writeformat),
+				ast_getformatname_multiple(nf, sizeof(nf), chan->nativeformats & AST_FORMAT_AUDIO_MASK));
 			ast_set_write_format(chan, fr->subclass.codec);
 		}