[asterisk-commits] irroot: branch 10 r335991 - in /branches/10: ./ channels/chan_agent.c

[SVN commits to the Asterisk project]

Author: irroot
Date: Thu Sep 15 03:29:12 2011
New Revision: 335991

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=335991
Log:
Merged revisions 335978 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r335978 | irroot | 2011-09-15 10:15:22 +0200 (Thu, 15 Sep 2011) | 11 lines
  
  lock the channel before calling ast_bridged_channel() to prevent a seg fault.
  
  AMI agents list called on shutdown causes a segfault, introducing proper locking
  will prevent this.
  
  (closes issue ASTERISK-18092)
  
  Reported by: agustina
  Patches: chan_agent.patch (License #5041) patch uploaded by irroot
........

Modified:
    branches/10/   (props changed)
    branches/10/channels/chan_agent.c

Propchange: branches/10/
------------------------------------------------------------------------------
Binary property 'branch-1.8-merged' - no diff available.

Modified: branches/10/channels/chan_agent.c
URL: http://svnview.digium.com/svn/asterisk/branches/10/channels/chan_agent.c?view=diff&rev=335991&r1=335990&r2=335991
==============================================================================
--- branches/10/channels/chan_agent.c (original)
+++ branches/10/channels/chan_agent.c Thu Sep 15 03:29:12 2011
@@ -1507,6 +1507,7 @@
 	char *talkingto = NULL;
 	char *talkingtoChan = NULL;
 	char *status = NULL;
+	struct ast_channel *bridge;
 
 	if (!ast_strlen_zero(id))
 		snprintf(idText, sizeof(idText) ,"ActionID: %s\r\n", id);
@@ -1531,10 +1532,13 @@
 			if (p->owner && p->owner->_bridge) {
 				talkingto = S_COR(p->chan->caller.id.number.valid,
 					p->chan->caller.id.number.str, "n/a");
-				if (ast_bridged_channel(p->owner))
-					talkingtoChan = ast_strdupa(ast_bridged_channel(p->owner)->name);
-				else
+				ast_channel_lock(p->owner);
+				if ((bridge = ast_bridged_channel(p->owner))) {
+					talkingtoChan = ast_strdupa(bridge->name);
+				} else {
 					talkingtoChan = "n/a";
+				}
+				ast_channel_unlock(p->owner);
 				status = "AGENT_ONCALL";
 			} else {
 				talkingto = "n/a";