[asterisk-commits] rmudgett: trunk r321045 - in /trunk: ./ include/asterisk/netsock2.h

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Thu May 26 13:10:50 CDT 2011


Author: rmudgett
Date: Thu May 26 13:10:46 2011
New Revision: 321045

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=321045
Log:
Merged revisions 321044 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r321044 | rmudgett | 2011-05-26 13:10:17 -0500 (Thu, 26 May 2011) | 1 line
  
  Update ast_sockaddr comment with an important note.
........

Modified:
    trunk/   (props changed)
    trunk/include/asterisk/netsock2.h

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.8-merged' - no diff available.

Modified: trunk/include/asterisk/netsock2.h
URL: http://svnview.digium.com/svn/asterisk/trunk/include/asterisk/netsock2.h?view=diff&rev=321045&r1=321044&r2=321045
==============================================================================
--- trunk/include/asterisk/netsock2.h (original)
+++ trunk/include/asterisk/netsock2.h Thu May 26 13:10:46 2011
@@ -43,12 +43,22 @@
 };
 
 /*!
- * Socket address structure. The first member is big enough to contain addresses
- * of any family. The second member contains the length (in bytes) used in the
- * first member.
- *
- * Some BSDs have the length embedded in sockaddr structs. We ignore them.
- * (This is the right thing to do.)
+ * \brief Socket address structure.
+ *
+ * \details
+ * The first member is big enough to contain addresses of any
+ * family. The second member contains the length (in bytes) used
+ * in the first member.
+ *
+ * \note
+ * Some BSDs have the length embedded in sockaddr structs. We
+ * ignore them. (This is the right thing to do.)
+ *
+ * \note
+ * It is important to always initialize ast_sockaddr before use
+ * -- even if they are passed to ast_sockaddr_copy() as the
+ * underlying storage could be bigger than what ends up being
+ * copied -- leaving part of the data unitialized.
  */
 struct ast_sockaddr {
 	struct sockaddr_storage	 ss;




More information about the asterisk-commits mailing list