[asterisk-commits] twilson: branch 1.8 r317584 - in /branches/1.8: ./ apps/app_queue.c

[SVN commits to the Asterisk project]

Author: twilson
Date: Fri May  6 03:18:53 2011
New Revision: 317584

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=317584
Log:
Merged revisions 317575 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r317575 | twilson | 2011-05-06 01:04:17 -0700 (Fri, 06 May 2011) | 13 lines
  
  Merged revisions 317574 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r317574 | twilson | 2011-05-06 00:55:21 -0700 (Fri, 06 May 2011) | 6 lines
    
    Re-fix queue round-robin
    
    This part of the change for r315596 was incorrect. No bridge occurs
    when doing a roundrobin dial and no one answers, so this code shouldn't
    have been removed.
  ........
................

Modified:
    branches/1.8/   (props changed)
    branches/1.8/apps/app_queue.c

Propchange: branches/1.8/
------------------------------------------------------------------------------
Binary property 'branch-1.6.2-merged' - no diff available.

Modified: branches/1.8/apps/app_queue.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/apps/app_queue.c?view=diff&rev=317584&r1=317583&r2=317584
==============================================================================
--- branches/1.8/apps/app_queue.c (original)
+++ branches/1.8/apps/app_queue.c Fri May  6 03:18:53 2011
@@ -4566,6 +4566,17 @@
 	if (need_weight)
 		ao2_unlock(queues);
 	lpeer = wait_for_answer(qe, outgoing, &to, &digit, numbusies, ast_test_flag(&(bridge_config.features_caller), AST_FEATURE_DISCONNECT), forwardsallowed, update_connectedline);
+	/* The ast_channel_datastore_remove() function could fail here if the
+	 * datastore was moved to another channel during a masquerade. If this is
+	 * the case, don't free the datastore here because later, when the channel
+	 * to which the datastore was moved hangs up, it will attempt to free this
+	 * datastore again, causing a crash
+	 */
+	ast_channel_lock(qe->chan);
+	if (datastore && !ast_channel_datastore_remove(qe->chan, datastore)) {
+		ast_datastore_free(datastore);
+	}
+	ast_channel_unlock(qe->chan);
 	ao2_lock(qe->parent);
 	if (qe->parent->strategy == QUEUE_STRATEGY_RRMEMORY || qe->parent->strategy == QUEUE_STRATEGY_RRORDERED) {
 		store_next_rr(qe, outgoing);