[asterisk-commits] pitel: branch 1.8 r300214 - /branches/1.8/res/

[SVN commits to the Asterisk project]

Author: pitel
Date: Tue Jan  4 11:01:52 2011
New Revision: 300214

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=300214
Log:
Memory leaking in calendars

ne_request_destroy() was missing in icalendar and exchange calendar modules, causing memory leak.

(closes issue #18521)
Review: https://reviewboard.asterisk.org/r/1068/

Modified:
    branches/1.8/res/res_calendar_exchange.c
    branches/1.8/res/res_calendar_icalendar.c

Modified: branches/1.8/res/res_calendar_exchange.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/res/res_calendar_exchange.c?view=diff&rev=300214&r1=300213&r2=300214
==============================================================================
--- branches/1.8/res/res_calendar_exchange.c (original)
+++ branches/1.8/res/res_calendar_exchange.c Tue Jan  4 11:01:52 2011
@@ -403,6 +403,7 @@
 	ne_add_request_header(req, "Content-type", "text/xml");
 
 	ret = ne_request_dispatch(req);
+	ne_request_destroy(req);
 
 	if (ret != NE_OK || !ast_str_strlen(response)) {
 		ast_log(LOG_WARNING, "Unknown response to CalDAV calendar %s, request %s to %s: %s\n", pvt->owner->name, method, pvt->url, ne_get_error(pvt->session));

Modified: branches/1.8/res/res_calendar_icalendar.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/res/res_calendar_icalendar.c?view=diff&rev=300214&r1=300213&r2=300214
==============================================================================
--- branches/1.8/res/res_calendar_icalendar.c (original)
+++ branches/1.8/res/res_calendar_icalendar.c Tue Jan  4 11:01:52 2011
@@ -142,6 +142,7 @@
 	ne_add_response_body_reader(req, ne_accept_2xx, fetch_response_reader, &response);
 
 	ret = ne_request_dispatch(req);
+	ne_request_destroy(req);
 	if (ret != NE_OK || !ast_str_strlen(response)) {
 		ast_log(LOG_WARNING, "Unable to retrieve iCalendar '%s' from '%s': %s\n", pvt->owner->name, pvt->url, ne_get_error(pvt->session));
 		ast_free(response);