[asterisk-commits] rmudgett: branch rmudgett/parking r330572 - /team/rmudgett/parking/main/

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Tue Aug  2 09:23:13 2011
New Revision: 330572

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=330572
Log:
Address park/unpark/recall collision concerns.

Modified:
    team/rmudgett/parking/main/features.c

Modified: team/rmudgett/parking/main/features.c
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/parking/main/features.c?view=diff&rev=330572&r1=330571&r2=330572
==============================================================================
--- team/rmudgett/parking/main/features.c (original)
+++ team/rmudgett/parking/main/features.c Tue Aug  2 09:23:13 2011
@@ -4329,7 +4329,6 @@
 					}
 				}
 
-/* BUGBUG need to check collision of recall call and parking pickup scenario. */
 				con = ast_context_find_or_create(NULL, NULL, parking_con_dial, registrar);
 				if (!con) {
 					ast_log(LOG_ERROR,
@@ -4701,10 +4700,8 @@
 		}
 	}
 	AST_LIST_TRAVERSE_SAFE_END;
-	AST_LIST_UNLOCK(&parkinglot->parkings);
-
 	if (pu) {
-/* BUGBUG do not want to remove the call from the parking lot until the parking pickup extension is removed.  park/unpark collision possible. */
+		/* Found a parked call to pickup. */
 		peer = pu->chan;
 		con = ast_context_find(parkinglot->cfg.parking_con);
 		if (con) {
@@ -4736,6 +4733,7 @@
 		parkinglot_unref(pu->parkinglot);
 		ast_free(pu);
 	}
+	AST_LIST_UNLOCK(&parkinglot->parkings);
 
 /* BUGBUG we need to update connected line for this connection. */