[asterisk-commits] twilson: branch 1.6.2 r315643 - in /branches/1.6.2: ./ apps/ main/

[SVN commits to the Asterisk project]

Author: twilson
Date: Tue Apr 26 16:27:44 2011
New Revision: 315643

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=315643
Log:
Merged revisions 315596 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r315596 | twilson | 2011-04-26 14:16:10 -0700 (Tue, 26 Apr 2011) | 18 lines
  
  Allow transfer loops without allowing forwarding loops
  
  We try to avoid the situation where two phones may be forwarded to each other
  causing an infinite loop by storing each dialed interface in a channel
  datastore and checking the list before dialing out. This works, but currently
  breaks situations like A calls B, A transfers B to C, B transfers C to A, and A
  transfers C to B. Since human interaction is happening here and not an
  automated forwarding loop, it should be allowed.
  
  This patch removes the dialed_interfaces datastore when a call is bridged (a
  suggestion from the brilliant mmichelson). If a call is being bridged, it
  should be safe to assume that we aren't stuck in a loop.
  
  Since we are now handling this is the bridge code, the previous attempts at
  handling it in app_dial and app_queue are removed.
  
  Review: https://reviewboard.asterisk.org/r/1195/
........

Modified:
    branches/1.6.2/   (props changed)
    branches/1.6.2/apps/app_dial.c
    branches/1.6.2/apps/app_queue.c
    branches/1.6.2/main/features.c

Propchange: branches/1.6.2/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: branches/1.6.2/apps/app_dial.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.2/apps/app_dial.c?view=diff&rev=315643&r1=315642&r2=315643
==============================================================================
--- branches/1.6.2/apps/app_dial.c (original)
+++ branches/1.6.2/apps/app_dial.c Tue Apr 26 16:27:44 2011
@@ -1912,14 +1912,6 @@
 
 	peer = wait_for_answer(chan, outgoing, &to, peerflags, &pa, &num, &result);
 
-	/* The ast_channel_datastore_remove() function could fail here if the
-	 * datastore was moved to another channel during a masquerade. If this is
-	 * the case, don't free the datastore here because later, when the channel
-	 * to which the datastore was moved hangs up, it will attempt to free this
-	 * datastore again, causing a crash
-	 */
-	if (!ast_channel_datastore_remove(chan, datastore))
-		ast_datastore_free(datastore);
 	if (!peer) {
 		if (result) {
 			res = result;

Modified: branches/1.6.2/apps/app_queue.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.2/apps/app_queue.c?view=diff&rev=315643&r1=315642&r2=315643
==============================================================================
--- branches/1.6.2/apps/app_queue.c (original)
+++ branches/1.6.2/apps/app_queue.c Tue Apr 26 16:27:44 2011
@@ -3843,17 +3843,6 @@
 	if (need_weight)
 		ao2_unlock(queues);
 	lpeer = wait_for_answer(qe, outgoing, &to, &digit, numbusies, ast_test_flag(&(bridge_config.features_caller), AST_FEATURE_DISCONNECT), forwardsallowed);
-	/* The ast_channel_datastore_remove() function could fail here if the
-	 * datastore was moved to another channel during a masquerade. If this is
-	 * the case, don't free the datastore here because later, when the channel
-	 * to which the datastore was moved hangs up, it will attempt to free this
-	 * datastore again, causing a crash
-	 */
-	ast_channel_lock(qe->chan);
-	if (datastore && !ast_channel_datastore_remove(qe->chan, datastore)) {
-		ast_datastore_free(datastore);
-	}
-	ast_channel_unlock(qe->chan);
 	ao2_lock(qe->parent);
 	if (qe->parent->strategy == QUEUE_STRATEGY_RRMEMORY || qe->parent->strategy == QUEUE_STRATEGY_RRORDERED) {
 		store_next_rr(qe, outgoing);

Modified: branches/1.6.2/main/features.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.2/main/features.c?view=diff&rev=315643&r1=315642&r2=315643
==============================================================================
--- branches/1.6.2/main/features.c (original)
+++ branches/1.6.2/main/features.c Tue Apr 26 16:27:44 2011
@@ -2832,6 +2832,22 @@
 	return;
 }
 
+static void clear_dialed_interfaces(struct ast_channel *chan)
+{
+	struct ast_datastore *di_datastore;
+
+	ast_channel_lock(chan);
+	if ((di_datastore = ast_channel_datastore_find(chan, &dialed_interface_info, NULL))) {
+		if (option_debug) {
+			ast_log(LOG_DEBUG, "Removing dialed interfaces datastore on %s since we're bridging\n", chan->name);
+		}
+		if (!ast_channel_datastore_remove(chan, di_datastore)) {
+			ast_datastore_free(di_datastore);
+		}
+	}
+	ast_channel_unlock(chan);
+}
+
 /*!
  * \brief bridge the call and set CDR
  * \param chan,peer,config
@@ -3001,6 +3017,13 @@
 		 * present. */
 		ast_clear_flag(bridge_cdr, AST_CDR_FLAG_DIALED);
 	}
+
+	/* If we are bridging a call, stop worrying about forwarding loops. We presume that if
+	 * a call is being bridged, that the humans in charge know what they're doing. If they
+	 * don't, well, what can we do about that? */
+	clear_dialed_interfaces(chan);
+	clear_dialed_interfaces(peer);
+
 	for (;;) {
 		struct ast_channel *other;	/* used later */