[asterisk-commits] russell: branch 1.6.2 r314778 - /branches/1.6.2/res/res_agi.c

[SVN commits to the Asterisk project]

Author: russell
Date: Fri Apr 22 08:58:03 2011
New Revision: 314778

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=314778
Log:
Initialize buffers in getvar and getvarfull.

Initialize the buffers used to hold the result from GET VARIABLE or
GET VARIABLE FULL.  The bug report shows func_read returning garbage in
the result.  It assumed that the buffer passed in was initialized, like many
other functions do.  In the more common code path (through the dialplan), it
is initialized, so just initialize it here too.

(closes issue #19050)
Reported by: johnz

Modified:
    branches/1.6.2/res/res_agi.c

Modified: branches/1.6.2/res/res_agi.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.2/res/res_agi.c?view=diff&rev=314778&r1=314777&r2=314778
==============================================================================
--- branches/1.6.2/res/res_agi.c (original)
+++ branches/1.6.2/res/res_agi.c Fri Apr 22 08:58:03 2011
@@ -1821,7 +1821,7 @@
 static int handle_getvariable(struct ast_channel *chan, AGI *agi, int argc, char **argv)
 {
 	char *ret;
-	char tempstr[1024];
+	char tempstr[1024] = "";
 
 	if (argc != 3)
 		return RESULT_SHOWUSAGE;
@@ -1843,7 +1843,7 @@
 
 static int handle_getvariablefull(struct ast_channel *chan, AGI *agi, int argc, char **argv)
 {
-	char tmp[4096];
+	char tmp[4096] = "";
 	struct ast_channel *chan2=NULL;
 
 	if ((argc != 4) && (argc != 5))