[asterisk-commits] tilghman: branch 1.4 r312285 - in /branches/1.4: include/asterisk/ main/

[SVN commits to the Asterisk project]

Author: tilghman
Date: Fri Apr  1 05:36:42 2011
New Revision: 312285

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=312285
Log:
Found some leaking file descriptors while looking at ast_FD_SETSIZE dead code.

(issue #18969)
 Reported by: oej
 Patches: 
       20110315__issue18969__14.diff.txt uploaded by tilghman (license 14)

Modified:
    branches/1.4/include/asterisk/select.h
    branches/1.4/main/asterisk.c

Modified: branches/1.4/include/asterisk/select.h
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/include/asterisk/select.h?view=diff&rev=312285&r1=312284&r2=312285
==============================================================================
--- branches/1.4/include/asterisk/select.h (original)
+++ branches/1.4/include/asterisk/select.h Fri Apr  1 05:36:42 2011
@@ -37,8 +37,9 @@
 #if !defined(HAVE_VARIABLE_FDSET) && defined(CONFIGURE_RAN_AS_ROOT)
 #define ast_fdset fd_set
 #else
+#define ast_FDMAX	32768
 typedef struct {
-	TYPEOF_FD_SET_FDS_BITS fds_bits[4096 / SIZEOF_FD_SET_FDS_BITS]; /* 32768 bits */
+	TYPEOF_FD_SET_FDS_BITS fds_bits[ast_FDMAX / 8 / SIZEOF_FD_SET_FDS_BITS]; /* 32768 bits */
 } ast_fdset;
 
 #undef FD_ZERO

Modified: branches/1.4/main/asterisk.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/main/asterisk.c?view=diff&rev=312285&r1=312284&r2=312285
==============================================================================
--- branches/1.4/main/asterisk.c (original)
+++ branches/1.4/main/asterisk.c Fri Apr  1 05:36:42 2011
@@ -2932,6 +2932,7 @@
 		fd2 = (l.rlim_cur > sizeof(readers) * 8 ? sizeof(readers) * 8 : l.rlim_cur) - 1;
 		if (dup2(fd, fd2) < 0) {
 			ast_log(LOG_WARNING, "Cannot open maximum file descriptor %d at boot? %s\n", fd2, strerror(errno));
+			close(fd);
 			break;
 		}
 
@@ -2940,9 +2941,12 @@
 		if (ast_select(fd2 + 1, &readers, NULL, NULL, &tv) < 0) {
 			ast_log(LOG_WARNING, "Maximum select()able file descriptor is %d\n", FD_SETSIZE);
 		}
+		ast_FD_SETSIZE = l.rlim_cur > ast_FDMAX ? ast_FDMAX : l.rlim_cur;
+		close(fd);
+		close(fd2);
 	} while (0);
 #elif defined(HAVE_VARIABLE_FDSET)
-	ast_FD_SETSIZE = l.rlim_cur;
+	ast_FD_SETSIZE = l.rlim_cur > ast_FDMAX ? ast_FDMAX : l.rlim_cur;
 #endif /* !defined(CONFIGURE_RAN_AS_ROOT) */
 
 	if ((!rungroup) && !ast_strlen_zero(ast_config_AST_RUN_GROUP))