[asterisk-commits] tilghman: branch 1.8 r287388 - in /branches/1.8: ./ apps/app_queue.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Fri Sep 17 16:08:54 2010
New Revision: 287388

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=287388
Log:
Merged revisions 287387 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r287387 | tilghman | 2010-09-17 16:08:00 -0500 (Fri, 17 Sep 2010) | 14 lines
  
  Merged revisions 287386 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r287386 | tilghman | 2010-09-17 16:06:03 -0500 (Fri, 17 Sep 2010) | 7 lines
    
    Blank columns should get set on reload, not ignored.
    
    (closes issue #16893)
     Reported by: haakon
     Patches: 
           20100818__issue16893.diff.txt uploaded by tilghman (license 14)
  ........
................

Modified:
    branches/1.8/   (props changed)
    branches/1.8/apps/app_queue.c

Propchange: branches/1.8/
------------------------------------------------------------------------------
Binary property 'branch-1.6.2-merged' - no diff available.

Modified: branches/1.8/apps/app_queue.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/apps/app_queue.c?view=diff&rev=287388&r1=287387&r2=287388
==============================================================================
--- branches/1.8/apps/app_queue.c (original)
+++ branches/1.8/apps/app_queue.c Fri Sep 17 16:08:54 2010
@@ -2114,10 +2114,10 @@
 		} else
 			tmp_name = v->name;
 
-		if (!ast_strlen_zero(v->value)) {
-			/* Don't want to try to set the option if the value is empty */
-			queue_set_param(q, tmp_name, v->value, -1, 0);
-		}
+		/* NULL values don't get returned from realtime; blank values should
+		 * still get set.  If someone doesn't want a value to be set, they
+		 * should set the realtime column to NULL, not blank. */
+		queue_set_param(q, tmp_name, v->value, -1, 0);
 	}
 
 	/* Temporarily set realtime members dead so we can detect deleted ones.