[asterisk-commits] tilghman: branch 1.4 r287386 - /branches/1.4/apps/app_queue.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Fri Sep 17 16:06:03 2010
New Revision: 287386

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=287386
Log:
Blank columns should get set on reload, not ignored.

(closes issue #16893)
 Reported by: haakon
 Patches: 
       20100818__issue16893.diff.txt uploaded by tilghman (license 14)

Modified:
    branches/1.4/apps/app_queue.c

Modified: branches/1.4/apps/app_queue.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/apps/app_queue.c?view=diff&rev=287386&r1=287385&r2=287386
==============================================================================
--- branches/1.4/apps/app_queue.c (original)
+++ branches/1.4/apps/app_queue.c Fri Sep 17 16:06:03 2010
@@ -1300,10 +1300,10 @@
 		} else
 			tmp_name = v->name;
 
-		if (!ast_strlen_zero(v->value)) {
-			/* Don't want to try to set the option if the value is empty */
-			queue_set_param(q, tmp_name, v->value, -1, 0);
-		}
+		/* NULL values don't get returned from realtime; blank values should
+		 * still get set.  If someone doesn't want a value to be set, they
+		 * should set the realtime column to NULL, not blank. */
+		queue_set_param(q, tmp_name, v->value, -1, 0);
 	}
 
 	if (q->strategy == QUEUE_STRATEGY_ROUNDROBIN)