[asterisk-commits] mnicholson: branch 1.6.2 r287308 - in /branches/1.6.2: ./ main/pbx.c

[SVN commits to the Asterisk project]

Author: mnicholson
Date: Fri Sep 17 08:36:07 2010
New Revision: 287308

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=287308
Log:
Merged revisions 287307 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r287307 | mnicholson | 2010-09-17 08:34:34 -0500 (Fri, 17 Sep 2010) | 5 lines
  
  Use ast_strdup() instead of ast_strdupa() while processing in ast_hint_state_changed().
  
  (related to issue #17928)
  Reported by: mdu113
........

Modified:
    branches/1.6.2/   (props changed)
    branches/1.6.2/main/pbx.c

Propchange: branches/1.6.2/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: branches/1.6.2/main/pbx.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.2/main/pbx.c?view=diff&rev=287308&r1=287307&r2=287308
==============================================================================
--- branches/1.6.2/main/pbx.c (original)
+++ branches/1.6.2/main/pbx.c Fri Sep 17 08:36:07 2010
@@ -3866,8 +3866,10 @@
 
 	AST_RWLIST_TRAVERSE(&hints, hint, list) {
 		struct ast_state_cb *cblist;
-		char *parse = ast_strdupa(ast_get_extension_app(hint->exten));
-		char *cur;
+		/* can't use ast_strdupa() here because we may run out of stack
+		 * space while looping over a large number of large strings */
+		char *dup = ast_strdup(ast_get_extension_app(hint->exten));
+		char *cur, *parse = dup;
 		int state;
 
 		while ( (cur = strsep(&parse, "&")) ) {
@@ -3875,6 +3877,9 @@
 				break;
 			}
 		}
+
+		ast_free(dup);
+
 		if (!cur) {
 			continue;
 		}