[asterisk-commits] pitel: branch 1.8 r287270 - /branches/1.8/res/res_calendar_ews.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Sep 17 03:42:41 CDT 2010


Author: pitel
Date: Fri Sep 17 03:42:37 2010
New Revision: 287270

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=287270
Log:
Asterisk crashing because of double free when EWS request fails

The free is done later in code. I think ast_free() should have built in checks for double free.

(closes issue #17782)

Modified:
    branches/1.8/res/res_calendar_ews.c

Modified: branches/1.8/res/res_calendar_ews.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/res/res_calendar_ews.c?view=diff&rev=287270&r1=287269&r2=287270
==============================================================================
--- branches/1.8/res/res_calendar_ews.c (original)
+++ branches/1.8/res/res_calendar_ews.c Fri Sep 17 03:42:37 2010
@@ -528,7 +528,6 @@
 	if (ret != NE_OK) { /* Error handling */
 		ast_log(LOG_WARNING, "Unable to communicate with Exchange Web Service at '%s': %s\n", ctx->pvt->url, ne_get_error(ctx->pvt->session));
 		ne_request_destroy(req);
-		ast_free(request);
 		ne_xml_destroy(parser);
 		return -1;
 	}




More information about the asterisk-commits mailing list