[asterisk-commits] rmudgett: trunk r291115 - /trunk/channels/chan_sip.c

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Mon Oct 11 14:07:59 2010
New Revision: 291115

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=291115
Log:
Add todo comment about handle_incoming() calling assumption.

Modified:
    trunk/channels/chan_sip.c

Modified: trunk/channels/chan_sip.c
URL: http://svnview.digium.com/svn/asterisk/trunk/channels/chan_sip.c?view=diff&rev=291115&r1=291114&r2=291115
==============================================================================
--- trunk/channels/chan_sip.c (original)
+++ trunk/channels/chan_sip.c Mon Oct 11 14:07:59 2010
@@ -23799,6 +23799,7 @@
 	struct sip_request *req;
 
 	while ((req = AST_LIST_REMOVE_HEAD(&p->request_queue, next))) {
+		/*! \todo XXX if nounlock is nonzero we do not have the channel lock anymore.  handle_incoming() assumes that it is locked. */
 		if (handle_incoming(p, req, &p->recv, recount, nounlock) == -1) {
 			/* Request failed */
 			ast_debug(1, "SIP message could not be handled, bad request: %-70.70s\n", p->callid[0] ? p->callid : "<no callid>");
@@ -24024,6 +24025,7 @@
 		process_request_queue(p, &recount, &nounlock);
 	}
 
+	/*! \todo XXX if nounlock is nonzero we do not have the channel lock anymore.  handle_incoming() assumes that it is locked. */
 	if (handle_incoming(p, req, addr, &recount, &nounlock) == -1) {
 		/* Request failed */
 		ast_debug(1, "SIP message could not be handled, bad request: %-70.70s\n", p->callid[0] ? p->callid : "<no callid>");