[asterisk-commits] tilghman: branch 1.4 r290392 - /branches/1.4/res/res_jabber.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Tue Oct  5 15:20:07 2010
New Revision: 290392

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=290392
Log:
Fix a crash by ensuring that we don't alter memory after it's freed.

(closes issue #17387)
 Reported by: jmls
 Patches: 
       20100726__issue17387.diff.txt uploaded by tilghman (license 14)
 Tested by: jmls

Modified:
    branches/1.4/res/res_jabber.c

Modified: branches/1.4/res/res_jabber.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/res/res_jabber.c?view=diff&rev=290392&r1=290391&r2=290392
==============================================================================
--- branches/1.4/res/res_jabber.c (original)
+++ branches/1.4/res/res_jabber.c Tue Oct  5 15:20:07 2010
@@ -1855,16 +1855,19 @@
 static int aji_client_connect(void *data, ikspak *pak)
 {
 	struct aji_client *client = ASTOBJ_REF((struct aji_client *) data);
-	int res = 0;
+	int res = IKS_FILTER_PASS;
 
 	if (client) {
 		if (client->state == AJI_DISCONNECTED) {
 			iks_filter_add_rule(client->f, aji_filter_roster, client, IKS_RULE_TYPE, IKS_PAK_IQ, IKS_RULE_SUBTYPE, IKS_TYPE_RESULT, IKS_RULE_ID, "roster", IKS_RULE_DONE);
 			client->state = AJI_CONNECTING;
 			client->jid = (iks_find_cdata(pak->query, "jid")) ? iks_id_new(client->stack, iks_find_cdata(pak->query, "jid")) : client->jid;
+			if (!client->component) { /*client*/
+				aji_get_roster(client);
+			}
 			iks_filter_remove_hook(client->f, aji_client_connect);
-			if(!client->component) /*client*/
-				aji_get_roster(client);
+			/* Once we remove the hook for this routine, we must return EAT or we will crash or corrupt memory */
+			res = IKS_FILTER_EAT;
 		}
 	} else
 		ast_log(LOG_ERROR, "Out of memory.\n");