[asterisk-commits] pabelanger: testsuite/asterisk/trunk r970 - /asterisk/trunk/runtests.py

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Nov 26 13:05:23 CST 2010


Author: pabelanger
Date: Fri Nov 26 13:05:21 2010
New Revision: 970

URL: http://svnview.digium.com/svn/testsuite?view=rev&rev=970
Log:
Do not include test-output.txt within <failure> element.

Currently, Bamboo will report a success if it cannot parse the results XML
file, this leads to Bamboo reporting 'false positives'.  This is a known
limitation of Bamboo and upstream bugs [1][2] have been filed.

[1] https://support.atlassian.com/browse/BSP-3734
[2] http://jira.atlassian.com/browse/BAM-7406

Additional, logic _should_ be added to validate our XML result files.


Modified:
    asterisk/trunk/runtests.py

Modified: asterisk/trunk/runtests.py
URL: http://svnview.digium.com/svn/testsuite/asterisk/trunk/runtests.py?view=diff&rev=970&r1=969&r2=970
==============================================================================
--- asterisk/trunk/runtests.py (original)
+++ asterisk/trunk/runtests.py Fri Nov 26 13:05:21 2010
@@ -338,14 +338,9 @@
             if t.passed is True:
                 f.write('/>\n')
                 continue
-            f.write(">\n\t\t<failure><![CDATA[\n")
-            try:
-                test_output = open("%s/test-output.txt" % t.test_name, "r")
-                f.write("%s" % test_output.read())
-                test_output.close()
-            except IOError:
-                print "Failed to open test output for %s" % t.test_name
-            f.write("\n\t\t]]></failure>\n\t</testcase>\n")
+            f.write(">\n\t\t<failure />")
+            f.write("\n\t</testcase>\n")
+
         f.write('</testsuite>\n')
         f.close()
 




More information about the asterisk-commits mailing list