[asterisk-commits] russell: branch 1.4 r296082 - /branches/1.4/main/channel.c

[SVN commits to the Asterisk project]

Author: russell
Date: Wed Nov 24 14:22:32 2010
New Revision: 296082

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=296082
Log:
Fix false reporting of an error by set_format().

In the case that the native format was able to be changed to match the
new requested format, the code proceeded to attempt to build a translation
path, anyway.  The result would be NULL, since no translation path is
necessary and resulted in this function thinking an error has occurred.
This case is now specifically caught and no attempt to build a translation
path is attempted.

Thanks to our automated tests and bamboo.asterisk.org for catching this problem
and making a whole lot of noise when things started failing.  :-)

Modified:
    branches/1.4/main/channel.c

Modified: branches/1.4/main/channel.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/main/channel.c?view=diff&rev=296082&r1=296081&r2=296082
==============================================================================
--- branches/1.4/main/channel.c (original)
+++ branches/1.4/main/channel.c Wed Nov 24 14:22:32 2010
@@ -3403,13 +3403,23 @@
 	if (*trans)
 		ast_translator_free_path(*trans);
 	/* Build a translation path from the raw format to the desired format */
-	if (!direction)
-		/* reading */
-		*trans = ast_translator_build_path(*format, *rawformat);
-	else
-		/* writing */
-		*trans = ast_translator_build_path(*rawformat, *format);
-	res = *trans ? 0 : -1;
+	if (*format == *rawformat) {
+		/*
+		 * If we were able to swap the native format to the format that
+		 * has been requested, then there is no need to try to build
+		 * a translation path.
+		 */
+		res = 0;
+	} else {
+		if (!direction) {
+			/* reading */
+			*trans = ast_translator_build_path(*format, *rawformat);
+		} else {
+			/* writing */
+			*trans = ast_translator_build_path(*rawformat, *format);
+		}
+		res = *trans ? 0 : -1;
+	}
 	ast_channel_unlock(chan);
 	if (option_debug)
 		ast_log(LOG_DEBUG, "Set channel %s to %s format %s\n", chan->name,