[asterisk-commits] mmichelson: trunk r263640 - in /trunk: ./ main/devicestate.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Mon May 17 17:08:01 2010
New Revision: 263640

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=263640
Log:
Merged revisions 263639 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r263639 | mmichelson | 2010-05-17 17:00:28 -0500 (Mon, 17 May 2010) | 10 lines
  
  Fix logic error when checking for a devstate provider.
  
  When using strsep, if one of the list of specified separators is not found,
  it is the first parameter to strsep which is now NULL, not the pointer returned
  by strsep.
  
  This issue isn't especially severe in that the worst it is likely to do is waste
  some cycles when a device with no '/' and no ':' is passed to ast_device_state.
........

Modified:
    trunk/   (props changed)
    trunk/main/devicestate.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/main/devicestate.c
URL: http://svnview.digium.com/svn/asterisk/trunk/main/devicestate.c?view=diff&rev=263640&r1=263639&r2=263640
==============================================================================
--- trunk/main/devicestate.c (original)
+++ trunk/main/devicestate.c Mon May 17 17:08:01 2010
@@ -323,8 +323,10 @@
 	buf = ast_strdupa(device);
 	tech = strsep(&buf, "/");
 	if (!(number = buf)) {
-		if (!(provider = strsep(&tech, ":")))
+		provider = strsep(&tech, ":");
+		if (!tech) {
 			return AST_DEVICE_INVALID;
+		}
 		/* We have a provider */
 		number = tech;
 		tech = NULL;