[asterisk-commits] lmadsen: branch 1.4 r263456 - /branches/1.4/main/http.c

[SVN commits to the Asterisk project]

Author: lmadsen
Date: Mon May 17 09:35:18 2010
New Revision: 263456

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=263456
Log:
Manager cookies are not compatible with RFC2109.

The Version field in the cookies we're setting contain quotes around the version
number which is not compatible with RFC2109 and breaks some implementations.

(closes issue #17231)
Reported by: ecarruda
Patches:
      manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559)
      manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559)
Tested by: ecarruda, russell

Modified:
    branches/1.4/main/http.c

Modified: branches/1.4/main/http.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/main/http.c?view=diff&rev=263456&r1=263455&r2=263456
==============================================================================
--- branches/1.4/main/http.c (original)
+++ branches/1.4/main/http.c Mon May 17 09:35:18 2010
@@ -572,7 +572,7 @@
 {
 	char *c;
 	c = buf;
-	ast_build_string(&c, &buflen, "Set-Cookie: %s=\"%s\"; Version=\"1\"", var, val);
+	ast_build_string(&c, &buflen, "Set-Cookie: %s=\"%s\"; Version=1", var, val);
 	if (expires)
 		ast_build_string(&c, &buflen, "; Max-Age=%d", expires);
 	ast_build_string(&c, &buflen, "\r\n");