[asterisk-commits] rmudgett: branch rmudgett/sig_ss7 r263198 - /team/rmudgett/sig_ss7/channels/

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Fri May 14 15:15:59 2010
New Revision: 263198

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=263198
Log:
Some comment clean up.

Modified:
    team/rmudgett/sig_ss7/channels/chan_dahdi.c
    team/rmudgett/sig_ss7/channels/sig_ss7.c

Modified: team/rmudgett/sig_ss7/channels/chan_dahdi.c
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/sig_ss7/channels/chan_dahdi.c?view=diff&rev=263198&r1=263197&r2=263198
==============================================================================
--- team/rmudgett/sig_ss7/channels/chan_dahdi.c (original)
+++ team/rmudgett/sig_ss7/channels/chan_dahdi.c Fri May 14 15:15:59 2010
@@ -6057,7 +6057,7 @@
 	struct dahdi_pvt *p = ast->tech_pvt;
 	int res = 0;
 	int idx;
-	ast_setstate(ast, AST_STATE_UP);/* BUGBUG this is redundantly set by the analog and PRI submodules! */
+	ast_setstate(ast, AST_STATE_UP);/*! \todo XXX this is redundantly set by the analog and PRI submodules! */
 	ast_mutex_lock(&p->lock);
 	idx = dahdi_get_index(ast, p, 0);
 	if (idx < 0)
@@ -12138,17 +12138,15 @@
 #if defined(HAVE_SS7)
 		case SIG_SS7:
 			if (ss7_chan) {
-/* BUGBUG check that all fields that need initialization are initialized */
-/* BUGBUG check that all fields that need synchronization between upper and submodule are synced with callbacks. */
 				ss7_chan->inalarm = tmp->inalarm;
-				ss7_chan->locallyblocked = tmp->locallyblocked;
-				ss7_chan->remotelyblocked = tmp->remotelyblocked;
 
 				ss7_chan->stripmsd = tmp->stripmsd;
 				ss7_chan->hidecallerid = tmp->hidecallerid;
 				ss7_chan->use_callerid = tmp->use_callerid;
 				ss7_chan->use_callingpres = tmp->use_callingpres;
 				ss7_chan->immediate = tmp->immediate;
+				ss7_chan->locallyblocked = tmp->locallyblocked;
+				ss7_chan->remotelyblocked = tmp->remotelyblocked;
 				ast_copy_string(ss7_chan->context, tmp->context,
 					sizeof(ss7_chan->context));
 				ast_copy_string(ss7_chan->mohinterpret, tmp->mohinterpret,

Modified: team/rmudgett/sig_ss7/channels/sig_ss7.c
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/sig_ss7/channels/sig_ss7.c?view=diff&rev=263198&r1=263197&r2=263198
==============================================================================
--- team/rmudgett/sig_ss7/channels/sig_ss7.c (original)
+++ team/rmudgett/sig_ss7/channels/sig_ss7.c Fri May 14 15:15:59 2010
@@ -680,8 +680,7 @@
 						sig_ss7_queue_control(linkset, chanpos, AST_CONTROL_PROGRESS);
 						p->progress = 1;
 						sig_ss7_set_dialing(p, 0);
-#if 0/* sig_pri seems to have just deleted this code. */
-/* BUGBUG dsp, dsp_features need equivalent. what done in sig_pri? */
+#if 0	/* This code no longer seems to be necessary so I did not convert it. */
 						if (p->dsp && p->dsp_features) {
 							ast_dsp_set_features(p->dsp, p->dsp_features);
 							p->dsp_features = 0;
@@ -1023,8 +1022,7 @@
 					p = linkset->pvts[chanpos];
 					sig_ss7_lock_private(p);
 					sig_ss7_queue_control(linkset, chanpos, AST_CONTROL_ANSWER);
-#if 0/* sig_pri seems to have just deleted this code. */
-/* BUGBUG dsp, dsp_features need equivalent. what done in sig_pri? */
+#if 0	/* This code no longer seems to be necessary so I did not convert it. */
 					if (p->dsp && p->dsp_features) {
 						ast_dsp_set_features(p->dsp, p->dsp_features);
 						p->dsp_features = 0;