[asterisk-commits] lmadsen: trunk r262798 - /trunk/res/ael/pval.c

[SVN commits to the Asterisk project]

Author: lmadsen
Date: Wed May 12 14:53:10 2010
New Revision: 262798

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=262798
Log:
Revert previous WARNING message removal.

Marquis42 suggested a better method of doing what I wanted because I ended up
removing the WARNING message for all instances when really I just wanted to
remove it for the 'return' keyword, not everything.

(issue #17145)

Modified:
    trunk/res/ael/pval.c

Modified: trunk/res/ael/pval.c
URL: http://svnview.digium.com/svn/asterisk/trunk/res/ael/pval.c?view=diff&rev=262798&r1=262797&r2=262798
==============================================================================
--- trunk/res/ael/pval.c (original)
+++ trunk/res/ael/pval.c Wed May 12 14:53:10 2010
@@ -2506,7 +2506,6 @@
 			|| strcasecmp(item->u1.str,"endwhile") == 0
 			|| strcasecmp(item->u1.str,"random") == 0
 			|| strcasecmp(item->u1.str,"gosub") == 0
-			|| strcasecmp(item->u1.str,"return") == 0
 			|| strcasecmp(item->u1.str,"gosubif") == 0
 			|| strcasecmp(item->u1.str,"continuewhile") == 0
 			|| strcasecmp(item->u1.str,"endwhile") == 0
@@ -2519,6 +2518,8 @@
 			|| strcasecmp(item->u1.str,"macroif") == 0
 			|| strcasecmp(item->u1.str,"stackpop") == 0
 			|| strcasecmp(item->u1.str,"execIf") == 0 ) {
+			ast_log(LOG_WARNING,"Warning: file %s, line %d-%d: application call to %s affects flow of control, and needs to be re-written using AEL if, while, goto, etc. keywords instead!\n",
+					item->filename, item->startline, item->endline, item->u1.str);
 			warns++;
 		}
 		if (strcasecmp(item->u1.str,"macroexit") == 0) {