[asterisk-commits] tilghman: trunk r273144 - /trunk/main/manager.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Tue Jun 29 20:07:02 2010
New Revision: 273144

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=273144
Log:
Permission checking for the system application is backwards.

(closes issue #17550)
 Reported by: kenner
 Patches: 
       manager.c.diff uploaded by kenner (license 1040)
 Tested by: kenner

Modified:
    trunk/main/manager.c

Modified: trunk/main/manager.c
URL: http://svnview.digium.com/svn/asterisk/trunk/main/manager.c?view=diff&rev=273144&r1=273143&r2=273144
==============================================================================
--- trunk/main/manager.c (original)
+++ trunk/main/manager.c Tue Jun 29 20:07:02 2010
@@ -3893,7 +3893,7 @@
 		/* To run the System application (or anything else that goes to shell), you must have the additional System privilege */
 		if (!(s->session->writeperm & EVENT_FLAG_SYSTEM)
 			&& (
-				strcasestr(app, "system") == 0 || /* System(rm -rf /)
+				strcasestr(app, "system") ||      /* System(rm -rf /)
 				                                     TrySystem(rm -rf /)       */
 				strcasestr(app, "exec") ||        /* Exec(System(rm -rf /))
 				                                     TryExec(System(rm -rf /)) */