[asterisk-commits] phsultan: branch phsultan/rtmp-support r272518 - in /team/phsultan/rtmp-suppo...
SVN commits to the Asterisk project
asterisk-commits at lists.digium.com
Fri Jun 25 06:41:45 CDT 2010
Author: phsultan
Date: Fri Jun 25 06:35:13 2010
New Revision: 272518
URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=272518
Log:
Merged revisions 252976,252980,253004,253028,253032,253113,253205,253255-253256,253261,253345,253357,253378,253490,253536-253540,253579,253712,253755,253758,253800,253872,253917,253958,254001,254045,254047,254050,254159,254162,254277,254321,254362,254406,254446,254450,254453-254454,254551,254553,254557,254636-254638,254715,254718,254799,254801-254802,254884,254931,254976,255021,255066,255117,255158,255199,255240,255281,255323,255410,255504,255592,255701,255751,255796,255850-255851,255906,255952,256010,256015,256019,256103-256104,256161,256265,256319,256370,256428,256485,256528-256530,256569,256608,256646,256661,256704,256745,256783,256821,256823,256860,256901,256985,257025,257032,257065,257146,257191,257262,257267,257343,257427,257493,257560,257642,257646,257713,257768,257810,257851,257857,257883,257947,257949,257988,258065,258106,258147,258149,258190,258227-258228,258256,258265,258305,258344-258345,258351,258383,258387,258433,258515,258517,258557,258595,258632,258671,258673-258675,258685,258776,258838,258855,258896,258934,258974,259023,259105,259189,259229,259307,259353,259357,259438-259439,259442,259451,259527,259533,259538,259587,259617,259672,259760,259837,259848,259853,259870,259957,260007,260050,260148,260231,260280,260292,260344,260346,260435,260437,260521,260570,260663,260757,260802,260924,261007,261051,261095,261124,261180,261232,261313-261314,261316,261364,261405,261451,261496,261500,261560,261609,261736,261822,261866-261867,261913,261917,261964,262005,262048,262102,262152,262236,262240,262299,262330,262414,262419,262422,262513,262569,262613,262656,262661,262743-262744,262796,262798,262800,262852,262895-262897,262940,262987,263028,263069,263151,263208,263250,263294,263375,263457,263460,263541,263589,263638,263640,263724,263807-263808,263810,263858,263860,263904-263905,263950,264031,264114,264117,264160-264161,264204,264249,264331,264335,264379,264400,264452,264497,264540,264626,264669,264711,264752,264779,264828,264905,264953,264997,265000,265087,265090,265174,265227,265273,265316-265317,265320,265366-265367,265449,265451,265453,265467,265525,265608,265611,265614,265698,265747,265793,265842,265844,265894,265923,266005-266006,266090,266092,266094,266098,266146,266238,266240,266289,266292,266337,266385-266386,266438,266522,266592,266682,266735,266786,266828,266832,266877,266926,267008,267041,267065,267093,267096-267097,267138,267181,267261,267303,267305,267350,267352,267399,267445,267490,267492,267537,267622,267624,267669,267714,267775,267819,267862-267863,267877,267928,267972,268051,268127,268205,268281,268321,268395,268417,268454,268456,268495,268534,268578,268653,268690,268731,268734,268773-268774,268817-268818,268857,268894,268896,268933,268969,268988,269007-269008,269083,269119,269153,269187,269196-269205,269238,269271,269307-269308,269346,269417,269486,269497,269569,269602,269636,269707,269711,269749,269822,269889,269936,269938,269976,270042,270079,270151,270184,270219,270260,270298,270332,270443,270519,270552,270584,270658,270660,270692,270726,270801,270836,270867,270936,270940,270974,270981,270983,270987,271056,271089,271124,271192,271231,271261-271262,271300,271336,271341,271483,271520,271551,271553-271554,271625,271657,271690,271762,271764,271831,271833,271867-271868,271903,271905,271977,272014,272052,272090,272109,272145-272146,272148,272150,272218,272243,272252,272254,272256-272257,272259-272260,272332,272368,272370,272447 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
................
r252976 | tilghman | 2010-03-17 00:49:35 +0100 (Wed, 17 Mar 2010) | 8 lines
Mask out previous arguments on each nested invocation of Gosub.
(closes issue #16758)
Reported by: wdoekes
Patches:
20100316__issue16758.diff.txt uploaded by tilghman (license 14)
Review: https://reviewboard.asterisk.org/r/561/
................
r252980 | tilghman | 2010-03-17 01:14:29 +0100 (Wed, 17 Mar 2010) | 2 lines
Fix bamboo compile error by calculating an integer with the same size as a pointer.
................
r253004 | tilghman | 2010-03-17 01:23:12 +0100 (Wed, 17 Mar 2010) | 2 lines
Argh.
................
r253028 | lmadsen | 2010-03-17 01:29:06 +0100 (Wed, 17 Mar 2010) | 13 lines
Merged revisions 253018 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r253018 | lmadsen | 2010-03-16 19:26:19 -0500 (Tue, 16 Mar 2010) | 6 lines
Add french snipset to say.conf.
Add the french snipset to say.conf.
(Closes issue #15799)
........
................
r253032 | lmadsen | 2010-03-17 01:40:51 +0100 (Wed, 17 Mar 2010) | 1 line
Fix a typo.
................
r253113 | tilghman | 2010-03-17 15:16:54 +0100 (Wed, 17 Mar 2010) | 2 lines
Switch to using intptr_t, as suggested by Kevin Fleming on the -dev list
................
r253205 | lmadsen | 2010-03-17 20:06:04 +0100 (Wed, 17 Mar 2010) | 4 lines
main/test.c reports erroneous CLI message.
(closes issue #17051)
Reported by: Nick_Lewis
................
r253255 | tilghman | 2010-03-18 16:45:26 +0100 (Thu, 18 Mar 2010) | 2 lines
Just in case of a race, send the signal on interrupt.
................
r253256 | lmadsen | 2010-03-18 16:46:52 +0100 (Thu, 18 Mar 2010) | 9 lines
Update to new Local channel documentation.
Add same changes as commit to 1.4, but convert to TeX.
(issue #16963)
Reported by: kobaz
Patches:
localchannel-2.txt uploaded by kobaz (license 834)
................
r253261 | phsultan | 2010-03-18 16:59:19 +0100 (Thu, 18 Mar 2010) | 8 lines
Prevent a crash when a buddy gets offline.
(closes issue #16760)
Reported by: fiddur
Patches:
248394.diff uploaded by fiddur (license 678)i with modifications by me
Tested by: fiddur, phsultan
................
r253345 | lmadsen | 2010-03-18 18:52:35 +0100 (Thu, 18 Mar 2010) | 7 lines
Change usage of pipe to comma in UserEvent docs.
Change the example usage of pipe as a separator to comma in the UserEvent
documentation.
(closes issue #16961)
Reported by: jlpedrosa
................
r253357 | russell | 2010-03-18 19:18:43 +0100 (Thu, 18 Mar 2010) | 8 lines
Increase CLI command output timeout for asterisk -rx to 60 seconds.
(closes issue #17049)
Reported by: russell
Tested by: russell
Review: https://reviewboard.asterisk.org/r/573/
................
r253378 | russell | 2010-03-18 19:23:07 +0100 (Thu, 18 Mar 2010) | 2 lines
Update comment to reflect new timeout value.
................
r253490 | alecdavis | 2010-03-19 08:37:00 +0100 (Fri, 19 Mar 2010) | 19 lines
prevent segfault if bad magic number is encountered.
internal_ao2_ref uses INTERNAL_OBJ which mzy report 'bad magic number', but
internal_ao2_ref continues on, causing segfault.
Although AO2_MAGIC number is checked by INTERNAL_OBJ before internal_ao2_ref is
called, A02_MAGIC is being destroyed (or a wrong pointer) by the time
internal_ao2_ref uses INTERNAL_OBJ.
internal_ao2_ref now returns -1 if INTERNAL_OBJ encouters a bad magic number.
(issue #17037)
Reported by: alecdavis
Patches:
bug17037.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis
................
r253536 | russell | 2010-03-20 12:33:30 +0100 (Sat, 20 Mar 2010) | 4 lines
Use SHRT_MAX instead of MAXSHORT.
These changes fix build issues I had with this module on FreeBSD.
................
r253537 | russell | 2010-03-20 12:39:39 +0100 (Sat, 20 Mar 2010) | 2 lines
Resolve a compiler warning on FreeBSD.
................
r253538 | russell | 2010-03-20 12:43:08 +0100 (Sat, 20 Mar 2010) | 2 lines
Resolve compiler warnings on FreeBSD.
................
r253539 | russell | 2010-03-20 12:47:40 +0100 (Sat, 20 Mar 2010) | 2 lines
Include sys/wait.h on FreeBSD to get the WEXITSTATUS() macro.
................
r253540 | russell | 2010-03-20 13:03:07 +0100 (Sat, 20 Mar 2010) | 2 lines
Resolve more compiler warnings on FreeBSD.
................
r253579 | russell | 2010-03-20 17:50:38 +0100 (Sat, 20 Mar 2010) | 5 lines
Fix memory corruption found by unit tests.
ast_str_reset() was being called on a potentially uninitialized pointer.
Valgrind is my hero, once again.
................
r253712 | tilghman | 2010-03-22 17:59:35 +0100 (Mon, 22 Mar 2010) | 2 lines
Accomodate equal signs in DSNs and add documentation, based upon mmichelson's feedback.
................
r253755 | tilghman | 2010-03-22 19:58:48 +0100 (Mon, 22 Mar 2010) | 4 lines
Return the list for later manipulation. This fixes an issue with the update procedure.
Debugging with mmichelson.
................
r253758 | tilghman | 2010-03-22 20:05:27 +0100 (Mon, 22 Mar 2010) | 2 lines
Update query should be an UPDATE, not a SELECT.
................
r253800 | mnicholson | 2010-03-22 20:52:52 +0100 (Mon, 22 Mar 2010) | 11 lines
Merged revisions 253799 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r253799 | mnicholson | 2010-03-22 14:50:00 -0500 (Mon, 22 Mar 2010) | 4 lines
Unconditionally copy the caller's account code to the called party.
(related to issue #16331)
........
................
r253872 | mmichelson | 2010-03-22 21:32:15 +0100 (Mon, 22 Mar 2010) | 8 lines
Initialize channels prior to loading "preload" modules.
We can have bad results when a module, upon being loaded, attempts
to reference the channels container if the container hasn't yet
been initialized. I saw this happen by trying to preload pbx_config.so
and having a hint defined which referenced a non-existent SIP peer.
................
r253917 | kpfleming | 2010-03-23 15:22:27 +0100 (Tue, 23 Mar 2010) | 23 lines
Change per-file debug and verbose levels to be per-module, the way
users expect them to work.
'core set debug' and 'core set verbose' can optionally change the
level for a specific filename; however, this is actually for a
specific source file name, not the module that source file is included
in. With examples like chan_sip, chan_iax2, chan_misdn and others
consisting of multiple source files, this will not lead to the
behavior that users expect. If they want to set the debug level for
chan_sip, they want it set for all of chan_sip, and not to have to
also set it for reqresp_parser and other files that comprise the
chan_sip module.
This patch changes this functionality to be module-name based instead
of file-name based.
To make this work, some Makefile modifications were required to ensure
that the AST_MODULE definition is present in each object file produced
for each module as well.
Review: https://reviewboard.asterisk.org/r/574/
................
r253958 | twilson | 2010-03-23 17:52:53 +0100 (Tue, 23 Mar 2010) | 4 lines
Don't act like an http write failed when it didn't
fwrite returns the number of items written, not the number of bytes
................
r254001 | tzafrir | 2010-03-23 20:19:52 +0100 (Tue, 23 Mar 2010) | 2 lines
Change the name of the category 'TEST' to match the name of the subdir
................
r254045 | seanbright | 2010-03-23 21:52:35 +0100 (Tue, 23 Mar 2010) | 5 lines
Remove unused structure member in app_queue.
(closes issue #15494)
Reported by: makoto
................
r254047 | qwell | 2010-03-23 22:09:32 +0100 (Tue, 23 Mar 2010) | 15 lines
Blocked revisions 254046 via svnmerge
........
r254046 | qwell | 2010-03-23 16:07:54 -0500 (Tue, 23 Mar 2010) | 9 lines
Allow out-of-tree modules to load, regardless of DEBUG_THREADS/DEBUG_CHANNEL_LOCKS differences.
This can be guaranteed by forcing the ABI to no longer change when these compiler flags are set.
An unfortunate side-effect to this is that there is an ABI change here. However, there is some
mitigation. Existing modules *will* fail to load since they would require functions that no
longer exist.
Review: https://reviewboard.asterisk.org/r/508/
........
................
r254050 | jpeeler | 2010-03-23 22:17:23 +0100 (Tue, 23 Mar 2010) | 14 lines
Exit native bridging early for greater timing accuracy with warnings
This changes native bridging to break one millisecond early so that the more
accurate timeval calculations done in the generic bridge can be performed using
the bridge config. Currently the time between exiting native bridging slightly
late can sometimes cause a large enough discrepancy for warnings to be missed.
For the record, 1.4 does not attempt to native bridge at all when warnings are
enabled.
(closes issue #15815)
Reported by: adomjan
Review: https://reviewboard.asterisk.org/r/577/
................
r254159 | russell | 2010-03-23 23:35:56 +0100 (Tue, 23 Mar 2010) | 2 lines
Put test output for a failure in a CDATA section in the XML results.
................
r254162 | tzafrir | 2010-03-23 23:48:03 +0100 (Tue, 23 Mar 2010) | 7 lines
make 'core show settings' should show all settable directories
(closes issue #17086)
Reported by: tzafrir
Patches:
asterisk_extra_settings_dirs.diff uploaded by tzafrir (license 46)
................
r254277 | jpeeler | 2010-03-24 18:15:05 +0100 (Wed, 24 Mar 2010) | 78 lines
Merged revisions 254235 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r254235 | jpeeler | 2010-03-23 19:37:23 -0500 (Tue, 23 Mar 2010) | 72 lines
Ensure that monitor recordings are written to the correct location (again)
This is an extension to 248860. As such the dialplan test has been extended:
; non absolute path, not combined
exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test)
exten => 5040, n, dial(sip/5001)
; absolute path, not combined
exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2)
exten => 5041, n, dial(sip/5001)
; no path, not combined
exten => 5042, 1, monitor(wav,monitor_test3)
exten => 5042, n, dial(sip/5001)
; combined: changemonitor from non absolute to no path (leaves tmp/jeff)
exten => 5043, 1, monitor(wav,tmp/jeff/monitor_test4,m)
exten => 5043, n, changemonitor(monitor_test5)
exten => 5043, n, dial(sip/5001)
; combined: changemonitor from no path to non absolute path
exten => 5044, 1, monitor(wav,monitor_test6,m)
exten => 5044, n, changemonitor(tmp/jeff/monitor_test7) ; this wasn't possible before
exten => 5044, n, dial(sip/5001)
; non absolute path, combined
exten => 5045, 1, monitor(wav,tmp/jeff/monitor_test8,m)
exten => 5045, n, dial(sip/5001)
; absolute path, combined
exten => 5046, 1, monitor(wav,/tmp/jeff/monitor_test9,m)
exten => 5046, n, dial(sip/5001)
; no path, combined
exten => 5047, 1, monitor(wav,monitor_test10,m)
exten => 5047, n, dial(sip/5001)
; combined: changemonitor from non absolute to absolute (leaves tmp/jeff)
exten => 5048, 1, monitor(wav,tmp/jeff/monitor_test11,m)
exten => 5048, n, changemonitor(/tmp/jeff/monitor_test12)
exten => 5048, n, dial(sip/5001)
; combined: changemonitor from absolute to non absolute (leaves /tmp/jeff)
exten => 5049, 1, monitor(wav,/tmp/jeff/monitor_test13,m)
exten => 5049, n, changemonitor(tmp/jeff/monitor_test14)
exten => 5049, n, dial(sip/5001)
; combined: changemonitor from no path to absolute
exten => 5050, 1, monitor(wav,monitor_test15,m)
exten => 5050, n, changemonitor(/tmp/jeff/monitor_test16)
exten => 5050, n, dial(sip/5001)
; combined: changemonitor from absolute to no path (leaves /tmp/jeff)
exten => 5051, 1, monitor(wav,/tmp/jeff/monitor_test17,m)
exten => 5051, n, changemonitor(monitor_test18)
exten => 5051, n, dial(sip/5001)
; not combined: changemonitor from non absolute to no path (leaves tmp/jeff)
exten => 5052, 1, monitor(wav,tmp/jeff/monitor_test19)
exten => 5052, n, changemonitor(monitor_test20)
exten => 5052, n, dial(sip/5001)
; not combined: changemonitor from no path to non absolute
exten => 5053, 1, monitor(wav,monitor_test21)
exten => 5053, n, changemonitor(tmp/jeff/monitor_test22)
exten => 5053, n, dial(sip/5001)
; not combined: changemonitor from non absolute to absolute (leaves tmp/jeff)
exten => 5054, 1, monitor(wav,tmp/jeff/monitor_test23)
exten => 5054, n, changemonitor(/tmp/jeff/monitor_test24)
exten => 5054, n, dial(sip/5001)
; not combined: changemonitor from absolute to non absolute (leaves /tmp/jeff)
exten => 5055, 1, monitor(wav,/tmp/jeff/monitor_test24)
exten => 5055, n, changemonitor(tmp/jeff/monitor_test25)
exten => 5055, n, dial(sip/5001)
; not combined: changemonitor from no path to absolute
exten => 5056, 1, monitor(wav,monitor_test26)
exten => 5056, n, changemonitor(/tmp/jeff/monitor_test27)
exten => 5056, n, dial(sip/5001)
; not combined: changemonitor from absolute to no path (leaves /tmp/jeff)
exten => 5057, 1, monitor(wav,/tmp/jeff/monitor_test28)
exten => 5057, n, changemonitor(monitor_test29)
exten => 5057, n, dial(sip/5001)
........
................
r254321 | jpeeler | 2010-03-24 19:13:29 +0100 (Wed, 24 Mar 2010) | 12 lines
Allow configuration of minsecs and nextaftercmd per mailbox.
Previously only configurable globally. A unit test has also been written to
provide protection against parse failures for supported mailbox options.
(closes issue #16864)
Reported by: kobaz
Patches:
voicemail2.patch uploaded by kobaz (license 834)
Review: https://reviewboard.asterisk.org/r/555/
................
r254362 | mmichelson | 2010-03-24 22:10:38 +0100 (Wed, 24 Mar 2010) | 41 lines
Fix potential invalid reads that could occur in pbx.c
Here is a cut and paste of my review request for this change:
This past weekend, Russell ran our current suite of unit tests for Asterisk
under valgrind. The PBX pattern match test caused valgrind to spew forth two
invalid read errors. This patch contains two changes that shut valgrind up and
do not cause any new memory leaks.
Change 1: In ast_context_remove_extension_callerid2, valgrind reported an
invalid read in the for loop close to the function's end. Specifically, one of
the the strcmp calls in the loop control was reading invalid memory. This was
because the caller of ast_context_remove_extension_callerid2 (__ast_context
destroy in this case) passed as a parameter a shallow copy of an ast_exten's
exten field. This same ast_exten was what was destroyed inside the for loop,
thus any iterations of the for loop beyond the destruction of the ast_exten
would result in invalid reads. My fix for this is to make a copy of the
ast_exten's exten field and pass the copy to
ast_context_remove_extension_callerid2. In addition, I have also acted
similarly with the ast_exten's matchcid field. Since in this case a NULL is
handled quite differently than an empty string, I needed to be a bit more
careful with its handling.
Change 2: In __ast_context_destroy, we iterated over a hashtab and called
ast_context_remove_extension_callerid2 on each item. Specifically, the hashtab
over which we were iterating was an ast_exten's peer_table. Inside of
ast_context_remove_extension_callerid2, we could possibly destroy this
ast_exten, which also caused the hashtab to be freed. Attempting to call
ast_hashtab_end_traversal on the hashtab iterator caused an invalid read to
occur when trying to read the iterator->tab->do_locking field since
iterator->tab had already been freed. My handling of this problem is a bit less
straightforward. With each iteration over the hashtab's contents, we set a
variable called "end_traversal" based on the return of
ast_context_remove_extension_callerid2. If 0 is ever returned, then we know
that the extension was found and destroyed. Because of this, we cannot call
ast_hashtab_end_traversal because we will be guaranteeing a read of invalid
memory. In such a case, we forego calling ast_hashtab_end_traversal and instead
call ast_free on the hashtab iterator.
Review: https://reviewboard.asterisk.org/r/585
................
r254406 | tzafrir | 2010-03-25 11:09:24 +0100 (Thu, 25 Mar 2010) | 10 lines
remove unneeded explicit channel in dahdi ioctls
This patch removes some cases where the channel number for an ioctl was
passed as a member in a struct rather then through the file descriptor.
The gain setting functions passed around a channel which is always 0,
and thus this parameter is simply dropped.
Review: https://reviewboard.asterisk.org/r/584/
................
r254446 | lmadsen | 2010-03-25 16:21:26 +0100 (Thu, 25 Mar 2010) | 9 lines
handle_speechset has 4 arguments.
Update code to reflect that handle_speechset has 4 arguments.
(closes issue #17093)
Reported by: gpatri
Patches:
res_agi.patch uploaded by gpatri (license 1014)
Tested by: pabelanger, mmichelson
................
r254450 | kpfleming | 2010-03-25 16:27:31 +0100 (Thu, 25 Mar 2010) | 49 lines
Improve handling of T.38 re-INVITEs that arrive before a T.38-capable
application is executing on a channel.
This patch addresses an issue found during working with end-users
using res_fax. If an incoming call is answered in the dialplan, or
jumps to the 'fax' extension due to reception of a CNG tone (with
faxdetect enabled), and then the remote endpoint sends a T.38
re-INVITE, it is possible for the channel's T.38 state to be
'T38_STATE_NEGOTIATING' when the application starts up. Unfortunately,
even if the application wants to use T.38, it can't respond to the
peer's negotiation request, because the AST_CONTROL_T38_PARAMETERS
control frame that chan_sip sent originally has been lost, and the
application needs the content of that frame to be able to formulate a
reply.
This patch adds a new 'request' type to AST_CONTROL_T38_PARAMETERS,
AST_T38_REQUEST_PARMS. If the application sends this request, chan_sip
will re-send the original control frame (with
AST_T38_REQUEST_NEGOTIATE as the request type), and the application
can respond as normal. If this occurs within the five second timeout
in chan_sip, the automatic cancellation of the peer reinvite will be
stopped, and the application will 'own' the negotiation process from
that point onwards.
This also improves the code path in chan_sip to allow sip_indicate(),
when called for AST_CONTROL_T38_PARAMETERS, to be able to return a
non-zero response, which should have been in place before since the
control frame *can* fail to be processed properly. It also modifies
ast_indicate() to return whatever result the channel driver returned
for this control frame, rather than converting all non-zero results
into '-1'. Finally, the new request type intentionally returns a
positive value, so that an application that sends
AST_T38_REQUEST_PARMS can know for certain whether the channel driver
accepted it and will be replying with a control frame of its own, or
whether it was ignored (if the sip_indicate()/ast_indicate() path had
properly supported failure responses before, this would not be
necessary).
This patch also modifies res_fax to take advantage of the new request.
In addition, this patch makes sip_t38_abort() actually lock the
private structure before doing its work... bad programmer, no donut.
This patch also enhances chan_sip's 'faxdetect' support to allow
triggering on T.38 re-INVITEs received as well as CNG tone detection.
Review: https://reviewboard.asterisk.org/r/556/
................
r254453 | twilson | 2010-03-25 17:03:51 +0100 (Thu, 25 Mar 2010) | 9 lines
Merged revisions 254451 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r254451 | twilson | 2010-03-25 10:57:29 -0500 (Thu, 25 Mar 2010) | 2 lines
Handle new SRCCHANGE control message here too
........
................
r254454 | mmichelson | 2010-03-25 17:04:48 +0100 (Thu, 25 Mar 2010) | 50 lines
Recorded merge of revisions 254452 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r254452 | mmichelson | 2010-03-25 10:59:56 -0500 (Thu, 25 Mar 2010) | 44 lines
Several fixes regarding RFC2833 DTMF detection.
Here is a copy and paste of the details from my request on
reviewboard that dealt with these changes:
Fix 1. The first change in place is to fix Mantis issue 15811, which deals with a situation where Asterisk will incorrectly interpret out of order RFC2833 frames as duplicate DTMF digits. For instance, we would receive a sequence like:
seqno 1: DTMF 1
seqno 2: DTMF 1
seqno 3: DTMF 1
seqno 4: DTMF 1
seqno 6: DTMF 1 (end)
seqno 5: DTMF 1
seqno 7: DTMF 1 (end)
seqno 8: DTMF 1 (end)
Prior to this patch when we received the frame with seqno 5, we would interpret this as a new DTMF 1. With this patch, we will check the seqno of the incoming digit and not process the frame if the seqno is lower than the last recorded seqno. Note that we do not record the seqno of the dropped DTMF frame for future processing. While the above situation is what was designed to be fixed, the patch is written in such a way that the following would also be fixed too:
seqno 9: DTMF 1
seqno 10: DTMF 1 (end)
seqno 11: DTMF 1 (end)
seqno 13: DTMF 2
seqno 12: DTMF 1 (end)
seqno 14: DTMF 2
seqno 15: DTMF 2 (end)
seqno 16: DTMF 2 (end)
seqno 17: DTMF 2 (end)
In this second situation, the beginning of the DTMF 2 arrives before the final end frame of the DTMF 1. With the patch, seqno 12 is no processed and thus we properly interpret the DTMF.
Fix 2. The second change in place is to fix an issue like the following:
seqno 1: DTMF 1
seqno 2: DTMF 1
seqno 3: DTMF 1 (end) *packet lost*
seqno 4: DTMF 1 (end) *packet lost*
seqno 5: DTMF 1 (end) *packet lost*
seqno 6: DTMF 2
When we receive seqno 6, we had code in place that was supposed to properly end the previously unended DTMF 1. The problem was that the code was essentially a no-op. The code would set up an end frame for the DTMF 1 but would immediately overwrite the frame with the begin for DTMF 2. I changed process_dtmf_rfc2833() so that instead of returning a single frame, it is given as an output parameter a list of frames. Each frame that needs to be returned is appended to this list.
Fix 3. The final change is a minor one where an AST_CONTROL_SRCCHANGE frame could get lost. If we process a cisco DTMF or an RFC 3389 frame and no frame was returned, then we would return &ast_null_frame. The problem is that earlier in the function, we may have generated an AST_CONTROL_SRCCHANGE frame and put it in the list of frames we wish to return. This frame would be lost in such a case. The patch fixes this problem
........
................
r254551 | mmichelson | 2010-03-25 18:29:47 +0100 (Thu, 25 Mar 2010) | 8 lines
Add new rtpsource options to the CHANNEL function.
This adds rtpsource options analogous to the rtpdest
functions that already exist. In addition, this fixes
potential crashes which could result due to trying to
read values from nonexistent RTP streams.
................
r254553 | mmichelson | 2010-03-25 18:42:36 +0100 (Thu, 25 Mar 2010) | 11 lines
Merged revisions 254552 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r254552 | mmichelson | 2010-03-25 12:33:35 -0500 (Thu, 25 Mar 2010) | 5 lines
Add doxygen for acl.h
Review: https://reviewboard.asterisk.org/r/528
........
................
r254557 | mmichelson | 2010-03-25 18:52:20 +0100 (Thu, 25 Mar 2010) | 17 lines
Add unit test for testing ACL functionality.
There are two unit tests contained here.
1. "Invalid ACL" This attempts to read a bunch of badly formatted ACL entries
and add them to a host access rule. The goal of this test is to be sure that
all invalid entries are rejected as they should be.
2. "ACL" This sets up four ACLs. One is a permit all, one is a deny all, and
the other two have specific rules about which subnets are allowed and which
are not. Then a set of test addresses is used to determine whether we would
allow those addresses to access us when each ACL is applied. This test, by the
way, was what resulted in AST-2010-003's creation.
Review: https://reviewboard.asterisk.org/r/532
................
r254636 | kpfleming | 2010-03-25 19:34:32 +0100 (Thu, 25 Mar 2010) | 3 lines
Get chan_ooh323 building again after recent build system changes.
................
r254637 | kpfleming | 2010-03-25 19:38:27 +0100 (Thu, 25 Mar 2010) | 8 lines
Remove no-longer-used (and unsafe) field in ast_channel for linked lists.
The ast_channel structure had a field used for linking a channel into a
linked list, but now that ast_channel structures are ao2 objects, this is
no longer needed, and could be harmful as ao2 objects really shouldn't
ever be placed into linked lists (since those lists don't assist with
reference count management on the objects).
................
r254638 | kpfleming | 2010-03-25 19:38:53 +0100 (Thu, 25 Mar 2010) | 3 lines
Bump cleancount due to ast_channel change.
................
r254715 | qwell | 2010-03-25 20:40:25 +0100 (Thu, 25 Mar 2010) | 10 lines
Blocked revisions 254714 via svnmerge
........
r254714 | qwell | 2010-03-25 14:39:23 -0500 (Thu, 25 Mar 2010) | 4 lines
Fix DEBUG_THREADS issue with out-of-tree modules.
Take 2, without ABI breakage this time.
........
................
r254718 | russell | 2010-03-25 21:08:40 +0100 (Thu, 25 Mar 2010) | 2 lines
chan_usbradio depends on alsa.
................
r254799 | russell | 2010-03-25 21:40:48 +0100 (Thu, 25 Mar 2010) | 2 lines
Fix chan_ooh323 so it works on Mac OS X, as well.
................
r254801 | russell | 2010-03-25 21:41:34 +0100 (Thu, 25 Mar 2010) | 2 lines
Resolve compiler warning on FreeBSD.
................
r254802 | qwell | 2010-03-25 21:41:49 +0100 (Thu, 25 Mar 2010) | 9 lines
Merged revisions 254800 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r254800 | qwell | 2010-03-25 15:41:15 -0500 (Thu, 25 Mar 2010) | 1 line
Don't remove local copies of utils in uninstall.
........
................
r254884 | russell | 2010-03-25 22:39:04 +0100 (Thu, 25 Mar 2010) | 2 lines
Fix a number of other build problems on Mac OS X.
................
r254931 | kpfleming | 2010-03-26 00:38:58 +0100 (Fri, 26 Mar 2010) | 6 lines
Use "local" instead of "system" header file inclusion.
Now that these files are in the tree, they should prefer the tree's local
copy of all Asterisk headers over any that may be installed.
................
r254976 | seanbright | 2010-03-26 17:27:56 +0100 (Fri, 26 Mar 2010) | 4 lines
Work around a bug in dash on Ubuntu by checking the number of arguments before shift'ing.
Reported and tested by pabelanger.
................
r255021 | lmadsen | 2010-03-26 20:07:38 +0100 (Fri, 26 Mar 2010) | 8 lines
Update confusing documentation for tlsbindaddr.
Update some confusing documentation for the tlsbindaddr
option in sip.conf.sample. Point at a link instead which
has better documentation.
(closes issue #17054)
Reported by: klaus3000
................
r255066 | lmadsen | 2010-03-26 20:27:56 +0100 (Fri, 26 Mar 2010) | 6 lines
Replace some documentation from 1.6.x back into trunk.
This documentation associated wth tlsbindaddr is still useful so lets
synchronize it between trunk and 1.6.x branches.
(issue #17054)
................
r255117 | tilghman | 2010-03-27 07:09:26 +0100 (Sat, 27 Mar 2010) | 7 lines
inotify support for pbx_spool
This should give a good speed boost, in that one particular thread isn't waking
up once a second to read directory contents.
Reviewboard: https://reviewboard.asterisk.org/r/137/
................
r255158 | seanbright | 2010-03-27 15:44:58 +0100 (Sat, 27 Mar 2010) | 2 lines
We need to inclde sys/wait.h on OpenBSD to get WEXITSTATUS.
................
r255199 | may | 2010-03-28 00:51:13 +0100 (Sun, 28 Mar 2010) | 3 lines
corrections in gk interface, small fixes in call clearing.
................
r255240 | russell | 2010-03-29 07:10:41 +0200 (Mon, 29 Mar 2010) | 2 lines
Remove a debugging log entry.
................
r255281 | jsmith | 2010-03-29 16:07:44 +0200 (Mon, 29 Mar 2010) | 7 lines
This patch adds custom device state handling for ConfBridge conferences,
matching the devstate handling of the MeetMe conferences.
Review: https://reviewboard.asterisk.org/r/572/
Closes issue #16972
................
r255323 | russell | 2010-03-30 18:07:49 +0200 (Tue, 30 Mar 2010) | 9 lines
Merged revisions 255322 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r255322 | russell | 2010-03-30 11:06:06 -0500 (Tue, 30 Mar 2010) | 2 lines
Don't make Asterisk not start if pbx_dundi fails to initialize.
........
................
r255410 | russell | 2010-03-30 22:56:26 +0200 (Tue, 30 Mar 2010) | 9 lines
Merged revisions 255409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r255409 | russell | 2010-03-30 15:56:00 -0500 (Tue, 30 Mar 2010) | 2 lines
Don't kill Asterisk if the H323 listener does not start.
........
................
r255504 | lmadsen | 2010-03-31 19:48:09 +0200 (Wed, 31 Mar 2010) | 5 lines
Add documentation clarifying when 't' and 'T' can be used.
(closes issue #17021)
Reported by: kovzol
Tested by: lmadsen, kovzol, davidw, ebroad
................
r255592 | tilghman | 2010-03-31 21:13:02 +0200 (Wed, 31 Mar 2010) | 22 lines
Recorded merge of revisions 255591 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r255591 | tilghman | 2010-03-31 14:09:46 -0500 (Wed, 31 Mar 2010) | 15 lines
Ensure line terminators in email are consistent.
Fixes an issue with certain Mail Transport Agents, where attachments are not
interpreted correctly.
(closes issue #16557)
Reported by: jcovert
Patches:
20100308__issue16557__1.4.diff.txt uploaded by tilghman (license 14)
20100308__issue16557__1.6.0.diff.txt uploaded by tilghman (license 14)
20100308__issue16557__trunk.diff.txt uploaded by tilghman (license 14)
Tested by: ebroad, zktech
Reviewboard: https://reviewboard.asterisk.org/r/544/
........
................
r255701 | mmichelson | 2010-04-01 00:35:20 +0200 (Thu, 01 Apr 2010) | 8 lines
Fix improper comaparison of anonymous URI when getting P-Asserted-Identity.
There was a bug where we split the URI on the @ sign and then attempted
to compare to "anonymous at anonymous.invalid" afterwards. This comparison
could never evaluate true. So now we keep a copy of the URI prior to the
split so that the comparison is valid.
................
r255751 | mnicholson | 2010-04-01 18:09:26 +0200 (Thu, 01 Apr 2010) | 2 lines
Removed documentation of the non existent 'both' option to 'faxdetect' in sip.conf
................
r255796 | tilghman | 2010-04-01 20:16:37 +0200 (Thu, 01 Apr 2010) | 7 lines
Fix DEBUG_THREADS build on Darwin.
(closes issue #16828)
Reported by: oej
Patches:
20100331__issue16828.diff.txt uploaded by tilghman (license 14)
................
r255850 | mvanbaak | 2010-04-02 08:43:31 +0200 (Fri, 02 Apr 2010) | 10 lines
Cleanup transmit_* functions
Bulk lot of generally trivial changes for cleaning up the transmit stuff. Line state request has been modified for line only responses.
(closes issue #16994)
Reported by: wedhorn
Patches:
skinny-clean07.diff uploaded by wedhorn (license 30)
Tested by: wedhorn
................
r255851 | mvanbaak | 2010-04-02 08:45:54 +0200 (Fri, 02 Apr 2010) | 7 lines
Ignore Redial softkey when no previous dialed number is known
(closes issue #17126)
Reported by: wedhorn
Patches:
skinny79xx_redial1.diff uploaded by wedhorn (license 30)
................
r255906 | kpfleming | 2010-04-02 20:57:58 +0200 (Fri, 02 Apr 2010) | 11 lines
Allow symbol export filtering to work properly on platforms that have symbol prefixes.
Some platforms prefix externally-visible symbols in object files generated
from C sources (most commonly, '_' is the prefix). On these platforms,
the existing symbol export filtering process ends up suppressing all the symbols
that are supposed to be left visible. This patch allows the prefix string
to be supplied to the top-level Makefile in the LINKER_SYMBOL_PREFIX variable,
and then generates the linker scripts as required to include the prefix
supplied.
................
r255952 | tilghman | 2010-04-02 22:19:01 +0200 (Fri, 02 Apr 2010) | 8 lines
Pass the PID of the Asterisk process, not the PID of the canary.
(closes issue #17065)
Reported by: globalnetinc
Patches:
astcanary.patch uploaded by makoto (license 38)
Tested by: frawd, globalnetinc
................
r256010 | russell | 2010-04-03 01:30:58 +0200 (Sat, 03 Apr 2010) | 9 lines
Merged revisions 256009 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r256009 | russell | 2010-04-02 18:30:15 -0500 (Fri, 02 Apr 2010) | 2 lines
Remove extremely verbose debug message.
........
................
r256015 | russell | 2010-04-03 01:46:45 +0200 (Sat, 03 Apr 2010) | 16 lines
Merged revisions 256014 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r256014 | russell | 2010-04-02 18:45:56 -0500 (Fri, 02 Apr 2010) | 9 lines
Resolve a deadlock that occurs due to a pointless call to ast_bridged_channel()
(closes issue #16840)
Reported by: bzing2
Patches:
patch.txt uploaded by bzing2 (license 902)
issue_16840.rev1.diff uploaded by russell (license 2)
Tested by: bzing2, russell
........
................
r256019 | russell | 2010-04-03 01:55:57 +0200 (Sat, 03 Apr 2010) | 10 lines
Export MEETMEBOOKID and fix pin-less conferences with realtime conferences
(closes issue #16866)
Reported by: DEA
Patches:
rt-meetme-options.txt uploaded by DEA (license 3)
Tested by: DEA
Review: https://reviewboard.asterisk.org/r/582/
................
r256103 | rmudgett | 2010-04-03 03:42:32 +0200 (Sat, 03 Apr 2010) | 5 lines
Using the Dial application f option when the call is forwarded will likely crash.
Fix app_dial.c:do_forward() OPT_FORCECLID setting cid.cid_num with a stack
allocated string instead of a heap allocated string.
................
r256104 | rmudgett | 2010-04-03 04:12:33 +0200 (Sat, 03 Apr 2010) | 8 lines
Consolidate ast_channel.cid.cid_rdnis into ast_channel.redirecting.from.number.
SWP-1229
ABE-2161
* Ensure chan_local.c:local_call() will not leak cid.cid_dnid when
copying.
................
r256161 | lmadsen | 2010-04-05 17:14:53 +0200 (Mon, 05 Apr 2010) | 1 line
Fix for localchannel.tex to allow PDFs to be generated again.
................
r256265 | rmudgett | 2010-04-06 02:39:44 +0200 (Tue, 06 Apr 2010) | 12 lines
Merged revisions 256225 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r256225 | rmudgett | 2010-04-05 19:10:16 -0500 (Mon, 05 Apr 2010) | 5 lines
DAHDI/PRI call to pri_channel_bridge() not protected by PRI lock.
SWP-1231
ABE-2163
........
................
r256319 | dvossel | 2010-04-06 16:42:10 +0200 (Tue, 06 Apr 2010) | 9 lines
fixes deadlock in chan_sip caused by usage of MASTER_CHANNEL dialplan function
(closes issue #16767)
Reported by: lmsteffan
Patches:
deadlock_16767v3.diff uploaded by dvossel (license 671)
Review: https://reviewboard.asterisk.org/r/606/
................
r256370 | tilghman | 2010-04-06 21:28:42 +0200 (Tue, 06 Apr 2010) | 2 lines
Mac OS X does not support comparing a mutex to its initializer. Create a test for this.
................
r256428 | kpfleming | 2010-04-08 18:35:10 +0200 (Thu, 08 Apr 2010) | 6 lines
Ensure that linker version scripts (used for symbol export control) always exist.
Using wildcard matching in the Makefile is not adequate to determine whether
an export file should exist for a module or not, so instead we'll just
create one if the module needs one, or copy the default one if it does not.
................
r256485 | mmichelson | 2010-04-09 16:37:50 +0200 (Fri, 09 Apr 2010) | 23 lines
func_srv and explicit specification of a remote IP for SIP.
More information about the asterisk-commits
mailing list