[asterisk-commits] rmudgett: trunk r267928 - /trunk/channels/sig_pri.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Jun 4 09:45:08 CDT 2010


Author: rmudgett
Date: Fri Jun  4 09:45:03 2010
New Revision: 267928

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=267928
Log:
Incoming overlap dialing no longer works after sig_pri extraction.

The problem would manifest itself if your dialplan matching could accept
more digits to match than were actually dialed.  The time out waiting for
overlap digits disconnected the call instead of matching any accumulated
digits to the dialplan.

Accidental conversion of a break out of loop as a break out of switch.

(closes issue #17401)
Reported by: avalentin
Patches:
      issue17401_digit_timeout.patch uploaded by rmudgett (license 664)
Tested by: avalentin, rmudgett

Modified:
    trunk/channels/sig_pri.c

Modified: trunk/channels/sig_pri.c
URL: http://svnview.digium.com/svn/asterisk/trunk/channels/sig_pri.c?view=diff&rev=267928&r1=267927&r2=267928
==============================================================================
--- trunk/channels/sig_pri.c (original)
+++ trunk/channels/sig_pri.c Fri Jun  4 09:45:03 2010
@@ -1477,7 +1477,7 @@
 			exten[len++] = res;
 			exten[len] = '\0';
 		} else
-			goto exit;
+			break;
 	}
 	/* if no extension was received ('unspecified') on overlap call, use the 's' extension */
 	if (ast_strlen_zero(exten)) {
@@ -1521,13 +1521,6 @@
 		/* Since we send release complete here, we won't get one */
 		p->call = NULL;
 	}
-	return NULL;
-
-exit:
-	res = sig_pri_play_tone(p, SIG_PRI_TONE_CONGESTION);
-	if (res < 0)
-		ast_log(LOG_WARNING, "Unable to play congestion tone on channel %d\n", p->channel);
-	ast_hangup(chan);
 	return NULL;
 }
 




More information about the asterisk-commits mailing list