[asterisk-commits] rmudgett: branch 1.6.2 r279207 - in /branches/1.6.2: ./ apps/

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Fri Jul 23 17:11:23 2010
New Revision: 279207

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=279207
Log:
Merged revisions 279206 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r279206 | rmudgett | 2010-07-23 16:56:44 -0500 (Fri, 23 Jul 2010) | 7 lines
  
  SIP promiscuous redirect could fail to dial the redirect.
  
  The ast_channel was created with one variable to ast_request() but the
  call to ast_call() that initiates the outgoing call was using a different
  variable.  The two variables are not equivalent if the call_forward string
  included a channel technology specifier.  e.g., SIP/200
........

Modified:
    branches/1.6.2/   (props changed)
    branches/1.6.2/apps/app_dial.c
    branches/1.6.2/apps/app_queue.c

Propchange: branches/1.6.2/
------------------------------------------------------------------------------
--- branch-1.4-merged (original)
+++ branch-1.4-merged Fri Jul 23 17:11:23 2010
@@ -1,1 +1,1 @@
-/branches/1.4:1-279056
+/branches/1.4:1-279056,279206

Modified: branches/1.6.2/apps/app_dial.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.2/apps/app_dial.c?view=diff&rev=279207&r1=279206&r2=279207
==============================================================================
--- branches/1.6.2/apps/app_dial.c (original)
+++ branches/1.6.2/apps/app_dial.c Fri Jul 23 17:11:23 2010
@@ -754,7 +754,9 @@
 			ast_channel_inherit_variables(in, o->chan);
 			ast_channel_datastore_inherit(in, o->chan);
 		} else
-			ast_log(LOG_NOTICE, "Unable to create local channel for call forward to '%s/%s' (cause = %d)\n", tech, stuff, cause);
+			ast_log(LOG_NOTICE,
+				"Forwarding failed to create channel to dial '%s/%s' (cause = %d)\n",
+				tech, stuff, cause);
 	}
 	if (!c) {
 		ast_clear_flag64(o, DIAL_STILLGOING);
@@ -785,8 +787,9 @@
 			S_REPLACE(c->cid.cid_ani, ast_strdup(in->cid.cid_ani));
 		}
 		S_REPLACE(c->cid.cid_rdnis, ast_strdup(S_OR(in->macroexten, in->exten)));
-		if (ast_call(c, tmpchan, 0)) {
-			ast_log(LOG_NOTICE, "Failed to dial on local channel for call forward to '%s'\n", tmpchan);
+		if (ast_call(c, stuff, 0)) {
+			ast_log(LOG_NOTICE, "Forwarding failed to dial '%s/%s'\n",
+				tech, stuff);
 			ast_clear_flag64(o, DIAL_STILLGOING);
 			ast_hangup(original);
 			ast_hangup(c);

Modified: branches/1.6.2/apps/app_queue.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.2/apps/app_queue.c?view=diff&rev=279207&r1=279206&r2=279207
==============================================================================
--- branches/1.6.2/apps/app_queue.c (original)
+++ branches/1.6.2/apps/app_queue.c Fri Jul 23 17:11:23 2010
@@ -2962,7 +2962,9 @@
 					/* Setup parameters */
 					o->chan = ast_request(tech, in->nativeformats, stuff, &status);
 					if (!o->chan) {
-						ast_log(LOG_NOTICE, "Unable to create local channel for call forward to '%s/%s'\n", tech, stuff);
+						ast_log(LOG_NOTICE,
+							"Forwarding failed to create channel to dial '%s/%s'\n",
+							tech, stuff);
 						o->stillgoing = 0;
 						numnochan++;
 					} else {
@@ -2987,8 +2989,9 @@
 						if (o->chan->cid.cid_rdnis)
 							ast_free(o->chan->cid.cid_rdnis);
 						o->chan->cid.cid_rdnis = ast_strdup(S_OR(in->macroexten, in->exten));
-						if (ast_call(o->chan, tmpchan, 0)) {
-							ast_log(LOG_NOTICE, "Failed to dial on local channel for call forward to '%s'\n", tmpchan);
+						if (ast_call(o->chan, stuff, 0)) {
+							ast_log(LOG_NOTICE, "Forwarding failed to dial '%s/%s'\n",
+								tech, stuff);
 							do_hang(o);
 							numnochan++;
 						}