[asterisk-commits] russell: branch 1.4 r275021 - in /branches/1.4: include/asterisk/ main/

[SVN commits to the Asterisk project]

Author: russell
Date: Fri Jul  9 10:33:08 2010
New Revision: 275021

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=275021
Log:
Document that a leading and trailing slash is expected for test categories.

Also, emit a warning if a test is registered without one of these.

Modified:
    branches/1.4/include/asterisk/test.h
    branches/1.4/main/test.c

Modified: branches/1.4/include/asterisk/test.h
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/include/asterisk/test.h?view=diff&rev=275021&r1=275020&r2=275021
==============================================================================
--- branches/1.4/include/asterisk/test.h (original)
+++ branches/1.4/include/asterisk/test.h Fri Jul  9 10:33:08 2010
@@ -154,7 +154,12 @@
 struct ast_test_info {
 	/*! \brief name of test, unique to category */
 	const char *name;
-	/*! \brief test category */
+	/*!
+	 * \brief test category
+	 *
+	 * Tests are categorized in a directory tree style hierarchy.  It is expected that
+	 * this string have both a leading and trailing forward slash ('/').
+	 */
 	const char *category;
 	/*! \brief optional short summary of test */
 	const char *summary;

Modified: branches/1.4/main/test.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/main/test.c?view=diff&rev=275021&r1=275020&r2=275021
==============================================================================
--- branches/1.4/main/test.c (original)
+++ branches/1.4/main/test.c Fri Jul  9 10:33:08 2010
@@ -547,6 +547,11 @@
 		return test_free(test);
 	}
 
+	if (test->info.category[0] != '/' || test->info.category[strlen(test->info.category) - 1] != '/') {
+		ast_log(LOG_WARNING, "Test category is missing a leading or trailing backslash for test %s%s",
+				test->info.category, test->info.name);
+	}
+
 	if (ast_strlen_zero(test->info.summary)) {
 		ast_log(LOG_WARNING, "Test %s/%s has no summary, test registration refused.\n",
 				test->info.category, test->info.name);