[asterisk-commits] mnicholson: trunk r273350 - /trunk/main/manager.c

[SVN commits to the Asterisk project]

Author: mnicholson
Date: Thu Jul  1 09:34:31 2010
New Revision: 273350

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=273350
Log:
Altered my comment about TCP_NODELAY

Modified:
    trunk/main/manager.c

Modified: trunk/main/manager.c
URL: http://svnview.digium.com/svn/asterisk/trunk/main/manager.c?view=diff&rev=273350&r1=273349&r2=273350
==============================================================================
--- trunk/main/manager.c (original)
+++ trunk/main/manager.c Thu Jul  1 09:34:31 2010
@@ -4610,10 +4610,9 @@
 		goto done;
 	}
 
- 	/* XXX here we set TCP_NODELAY on the socket to disable Nagle's
- 	 * algorithm.  A better solution might be to buffer outgoing messages
- 	 * until they are complete then write them to the socket in one burst
- 	 * rather than sending them in bits and pieces. */
+	/* here we set TCP_NODELAY on the socket to disable Nagle's algorithm.
+	 * This is necessary to prevent delays (caused by buffering) as we
+	 * write to the socket in bits and peices. */
   	p = getprotobyname("tcp");
   	if (p) {
   		int arg = 1;