[asterisk-commits] seanbright: trunk r238014 - /trunk/addons/format_mp3.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Wed Jan 6 09:35:47 CST 2010


Author: seanbright
Date: Wed Jan  6 09:35:43 2010
New Revision: 238014

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=238014
Log:
Fix reading samples from format_mp3 after ast_seekstream/ast_tellstream.

There is a bug when using ast_seekstream/ast_tellstream with format_mp3 in that
the file read position is not reset before attempting to read samples.  So when
we seek to determine the maximum size of the file (as in res_agi's STREAM FILE)
we weren't then resetting the file pointer so that we could properly read
samples.  This patch addresses that (in a similar manner to format_wav.c).

(closes issue #15224)
Reported by: rbd
Patches:
      20091230_addons_1.4_issue15224.diff uploaded by seanbright (license 71)
Tested by: rbd, seanbright

Review: https://reviewboard.asterisk.org/r/453

Modified:
    trunk/addons/format_mp3.c

Modified: trunk/addons/format_mp3.c
URL: http://svnview.digium.com/svn/asterisk/trunk/addons/format_mp3.c?view=diff&rev=238014&r1=238013&r2=238014
==============================================================================
--- trunk/addons/format_mp3.c (original)
+++ trunk/addons/format_mp3.c Wed Jan  6 09:35:43 2010
@@ -264,7 +264,7 @@
 	}
 
 	p->seek = offset;
-	return p->seek;
+	return fseek(s->f, offset, SEEK_SET);
 	
 }
 




More information about the asterisk-commits mailing list