[asterisk-commits] mmichelson: branch 1.6.0 r247338 - in /branches/1.6.0: ./ include/asterisk/ m...

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Wed Feb 17 15:35:29 2010
New Revision: 247338

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=247338
Log:
Merged revisions 247335 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r247335 | mmichelson | 2010-02-17 15:22:40 -0600 (Wed, 17 Feb 2010) | 20 lines
  
  Fix two problems in ast_str functions found while writing a unit test.
  
  1. The documentation for ast_str_set and ast_str_append state that
  the max_len parameter may be -1 in order to limit the size of the
  ast_str to its current allocated size. The problem was that the max_len
  parameter in all cases was a size_t, which is unsigned. Thus a -1 was
  interpreted as UINT_MAX instead of -1. Changing the max_len parameter
  to be ssize_t fixed this issue.
  
  2. Once issue 1 was fixed, there was an off-by-one error in the case
  where we attempted to write a string larger than the current allotted
  size to a string when -1 was passed as the max_len parameter. When trying
  to write more than the allotted size, the ast_str's __AST_STR_USED was
  set to 1 higher than it should have been. Thanks to Tilghman for quickly
  spotting the offending line of code.
  
  Oh, and the unit test that I referenced in the top line of this commit
  will be added to reviewboard shortly. Sit tight...
........

Modified:
    branches/1.6.0/   (props changed)
    branches/1.6.0/include/asterisk/strings.h
    branches/1.6.0/main/utils.c

Propchange: branches/1.6.0/
------------------------------------------------------------------------------
Binary property 'trunk-merged' - no diff available.

Modified: branches/1.6.0/include/asterisk/strings.h
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.0/include/asterisk/strings.h?view=diff&rev=247338&r1=247337&r2=247338
==============================================================================
--- branches/1.6.0/include/asterisk/strings.h (original)
+++ branches/1.6.0/include/asterisk/strings.h Wed Feb 17 15:35:29 2010
@@ -640,7 +640,7 @@
  *       through calling one of the other functions or macros defined in this
  *       file.
  */
-int __attribute__((format(printf, 4, 0))) __ast_str_helper(struct ast_str **buf, size_t max_len,
+int __attribute__((format(printf, 4, 0))) __ast_str_helper(struct ast_str **buf, ssize_t max_len,
 							   int append, const char *fmt, va_list ap);
 
 /*!
@@ -662,7 +662,7 @@
  */
 AST_INLINE_API(
 int __attribute__((format(printf, 3, 4))) ast_str_set(
-	struct ast_str **buf, size_t max_len, const char *fmt, ...),
+	struct ast_str **buf, ssize_t max_len, const char *fmt, ...),
 {
 	int res;
 	va_list ap;
@@ -683,7 +683,7 @@
  */
 AST_INLINE_API(
 int __attribute__((format(printf, 3, 4))) ast_str_append(
-	struct ast_str **buf, size_t max_len, const char *fmt, ...),
+	struct ast_str **buf, ssize_t max_len, const char *fmt, ...),
 {
 	int res;
 	va_list ap;

Modified: branches/1.6.0/main/utils.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.6.0/main/utils.c?view=diff&rev=247338&r1=247337&r2=247338
==============================================================================
--- branches/1.6.0/main/utils.c (original)
+++ branches/1.6.0/main/utils.c Wed Feb 17 15:35:29 2010
@@ -1655,7 +1655,7 @@
  *	ast_str_append_va(...)
  */
 
-int __ast_str_helper(struct ast_str **buf, size_t max_len,
+int __ast_str_helper(struct ast_str **buf, ssize_t max_len,
 	int append, const char *fmt, va_list ap)
 {
 	int res, need;
@@ -1692,7 +1692,7 @@
 		return AST_DYNSTR_BUILD_RETRY;
 	}
 	/* update space used, keep in mind the truncation */
-	(*buf)->used = (res + offset > (*buf)->len) ? (*buf)->len : res + offset;
+	(*buf)->used = (res + offset > (*buf)->len) ? (*buf)->len - 1 : res + offset;
 
 	return res;
 }