[asterisk-commits] tilghman: trunk r246022 - /trunk/funcs/func_strings.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Wed Feb 10 09:36:57 2010
New Revision: 246022

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=246022
Log:
Enable warnings on atypical conditions for the FILTER function (suggested by mmichelson on the -dev list).

Modified:
    trunk/funcs/func_strings.c

Modified: trunk/funcs/func_strings.c
URL: http://svnview.digium.com/svn/asterisk/trunk/funcs/func_strings.c?view=diff&rev=246022&r1=246021&r2=246022
==============================================================================
--- trunk/funcs/func_strings.c (original)
+++ trunk/funcs/func_strings.c Wed Feb 10 09:36:57 2010
@@ -603,6 +603,10 @@
 		return -1;
 	}
 
+	if (args.allowed[0] == '"' && !ast_opt_dont_warn) {
+		ast_log(LOG_WARNING, "FILTER allowed characters includes the quote (\") character.  This may not be what you want.\n");
+	}
+
 	/* Expand ranges */
 	for (; *(args.allowed) && allowedlen < sizeof(allowed); ) {
 		char c1 = 0, c2 = 0;
@@ -616,6 +620,10 @@
 			if (ast_get_encoded_char(args.allowed + 1, &c2, &consumed))
 				c2 = -1;
 			args.allowed += consumed + 1;
+
+			if ((c2 < c1 || c2 == -1) && !ast_opt_dont_warn) {
+				ast_log(LOG_WARNING, "Range wrapping in FILTER(%s,%s).  This may not be what you want.\n", parse, args.string);
+			}
 
 			/*!\note
 			 * Looks a little strange, until you realize that we can overflow