[asterisk-commits] dvossel: branch dvossel/sip_nonblocking_tcp_client r220712 - /team/dvossel/si...

[SVN commits to the Asterisk project]

Author: dvossel
Date: Mon Sep 28 12:02:44 2009
New Revision: 220712

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=220712
Log:
Making a reference to tcptls_session within the cleanup label
in the tcp helper thread is not safe since we are not guaranteed
the tcptls_session exists at that point.


Modified:
    team/dvossel/sip_nonblocking_tcp_client/channels/chan_sip.c

Modified: team/dvossel/sip_nonblocking_tcp_client/channels/chan_sip.c
URL: http://svnview.digium.com/svn/asterisk/team/dvossel/sip_nonblocking_tcp_client/channels/chan_sip.c?view=diff&rev=220712&r1=220711&r2=220712
==============================================================================
--- team/dvossel/sip_nonblocking_tcp_client/channels/chan_sip.c (original)
+++ team/dvossel/sip_nonblocking_tcp_client/channels/chan_sip.c Mon Sep 28 12:02:44 2009
@@ -3218,6 +3218,8 @@
 		}
 	}
 
+	ast_debug(2, "Shutting down thread for %s server\n", tcptls_session->ssl ? "SSL" : "TCP");
+
 cleanup:
 	if (me) {
 		ao2_t_unlink(threadl, me, "Removing tcptls helper thread, thread is closing");
@@ -3231,8 +3233,6 @@
 		ast_free(req.data);
 		req.data = NULL;
 	}
-
-	ast_debug(2, "Shutting down thread for %s server\n", tcptls_session->ssl ? "SSL" : "TCP");
 
 	/* if client, we own the parent session arguments and must decrement ref */
 	if (ca) {