[asterisk-commits] tilghman: trunk r220289 - in /trunk: ./ apps/ main/

[SVN commits to the Asterisk project]

Author: tilghman
Date: Thu Sep 24 14:41:02 2009
New Revision: 220289

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=220289
Log:
Merged revisions 220288 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220288 | tilghman | 2009-09-24 14:39:41 -0500 (Thu, 24 Sep 2009) | 6 lines
  
  Implicitly sending a progress signal breaks some applications.
  Call Progress() in your dialplan if you explicitly want progress to be sent.
  (Reverts change 216430, closes issue #15957)
  Reported by: Pavel Troller on the Asterisk-Dev mailing list
  http://lists.digium.com/pipermail/asterisk-dev/2009-September/039897.html
........

Modified:
    trunk/   (props changed)
    trunk/apps/app_disa.c
    trunk/apps/app_playback.c
    trunk/main/pbx.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/apps/app_disa.c
URL: http://svnview.digium.com/svn/asterisk/trunk/apps/app_disa.c?view=diff&rev=220289&r1=220288&r2=220289
==============================================================================
--- trunk/apps/app_disa.c (original)
+++ trunk/apps/app_disa.c Thu Sep 24 14:41:02 2009
@@ -187,12 +187,7 @@
 			/* answer */
 			ast_answer(chan);
 		}
-	} else {
-		special_noanswer = 1;
-		if (chan->_state != AST_STATE_UP) {
-			ast_indicate(chan, AST_CONTROL_PROGRESS);
-		}
-	}
+	} else special_noanswer = 1;
 
 	ast_debug(1, "Context: %s\n",args.context);
 

Modified: trunk/apps/app_playback.c
URL: http://svnview.digium.com/svn/asterisk/trunk/apps/app_playback.c?view=diff&rev=220289&r1=220288&r2=220289
==============================================================================
--- trunk/apps/app_playback.c (original)
+++ trunk/apps/app_playback.c Thu Sep 24 14:41:02 2009
@@ -452,10 +452,7 @@
 		} else if (!option_noanswer) {
 			/* Otherwise answer unless we're supposed to send this while on-hook */
 			res = ast_answer(chan);
-		} else {
-			ast_indicate(chan, AST_CONTROL_PROGRESS);
-		}
-
+		}
 	}
 	if (!res) {
 		char *back = args.filenames;

Modified: trunk/main/pbx.c
URL: http://svnview.digium.com/svn/asterisk/trunk/main/pbx.c?view=diff&rev=220289&r1=220288&r2=220289
==============================================================================
--- trunk/main/pbx.c (original)
+++ trunk/main/pbx.c Thu Sep 24 14:41:02 2009
@@ -9126,8 +9126,6 @@
 		} else if (!ast_test_flag(&flags, BACKGROUND_NOANSWER)) {
 			res = ast_answer(chan);
 		}
-		/* Send progress control frame to start early media */
-		ast_indicate(chan, AST_CONTROL_PROGRESS);
 	}
 
 	if (!res) {