[asterisk-commits] mmichelson: trunk r218933 - /trunk/channels/chan_sip.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Wed Sep 16 14:25:36 2009
New Revision: 218933

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=218933
Log:
Reverse order of args to fread.

This way, we don't always write a null byte into
byte 1 of the buffer

(closes issue #15905)
Reported by: ebroad
Patches:
      freadfix.patch uploaded by ebroad (license 878)
Tested by: ebroad


Modified:
    trunk/channels/chan_sip.c

Modified: trunk/channels/chan_sip.c
URL: http://svn.asterisk.org/svn-view/asterisk/trunk/channels/chan_sip.c?view=diff&rev=218933&r1=218932&r2=218933
==============================================================================
--- trunk/channels/chan_sip.c (original)
+++ trunk/channels/chan_sip.c Wed Sep 16 14:25:36 2009
@@ -2964,7 +2964,7 @@
 			while (cl > 0) {
 				size_t bytes_read;
 				ast_mutex_lock(&tcptls_session->lock);
-				if (!(bytes_read = fread(buf, MIN(sizeof(buf) - 1, cl), 1, tcptls_session->f))) {
+				if (!(bytes_read = fread(buf, 1, MIN(sizeof(buf) - 1, cl), tcptls_session->f))) {
 					ast_mutex_unlock(&tcptls_session->lock);
 					goto cleanup;
 				}