[asterisk-commits] mmichelson: branch group/CCSS r225242 - /team/group/CCSS/main/ccss.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Wed Oct 21 15:34:13 2009
New Revision: 225242

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=225242
Log:
Add some missing break statements to cc_do_state_change


Modified:
    team/group/CCSS/main/ccss.c

Modified: team/group/CCSS/main/ccss.c
URL: http://svnview.digium.com/svn/asterisk/team/group/CCSS/main/ccss.c?view=diff&rev=225242&r1=225241&r2=225242
==============================================================================
--- team/group/CCSS/main/ccss.c (original)
+++ team/group/CCSS/main/ccss.c Wed Oct 21 15:34:13 2009
@@ -2303,10 +2303,12 @@
 				(core_instance->current_state == CC_AVAILABLE && ast_test_flag(core_instance->agent, AST_CC_AGENT_SKIP_OFFER)))) {
 			ast_log(LOG_NOTICE, "Invalid state change request. Cannot go from %d to %d\n",
 					core_instance->current_state, args->state);
+			break;
 		}
 		if (!ast_cc_request_within_limits()) {
 			ast_log(LOG_WARNING, "Cannot request CC since there is no more room for requests\n");
 			ast_cc_failed(core_instance->core_id, "Too many requests in the system");
+			break;
 		}
 		core_instance->current_state = args->state;
 		core_instance->agent->callbacks->stop_offer_timer(core_instance->agent);
@@ -2356,6 +2358,7 @@
 		if (core_instance->current_state != CC_CALLEE_READY) {
 			ast_log(LOG_NOTICE, "Invalid state change request. Cannot go from %d to %d\n",
 					core_instance->current_state, args->state);
+			break;
 		}
 		core_instance->current_state = args->state;
 		core_instance->monitor->callbacks->suspend(core_instance->monitor, core_instance->core_id);
@@ -2367,6 +2370,7 @@
 		if (core_instance->current_state != CC_CALLEE_READY) {
 			ast_log(LOG_NOTICE, "Invalid state change request. Cannot go from %d to %d\n",
 					core_instance->current_state, args->state);
+			break;
 		}
 		core_instance->current_state = args->state;
 		core_instance->monitor->callbacks->cancel_available_timer(core_instance->monitor, core_instance->core_id, NULL);
@@ -2378,6 +2382,7 @@
 		if (core_instance->current_state != CC_RECALLING) {
 			ast_log(LOG_NOTICE, "Invalid state change request. Cannot go from %d to %d\n",
 					core_instance->current_state, args->state);
+			break;
 		}
 		core_instance->current_state = args->state;
 		ao2_t_unlink(cc_core_instances, core_instance, "Unlink core instance since CC recall has completed");