[asterisk-commits] mmichelson: branch group/CCSS r224445 - /team/group/CCSS/main/ccss.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Sun Oct 18 16:40:53 2009
New Revision: 224445

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=224445
Log:
Add XXX note about a necessary change to discover the
name of a device which may be monitored.


Modified:
    team/group/CCSS/main/ccss.c

Modified: team/group/CCSS/main/ccss.c
URL: http://svnview.digium.com/svn/asterisk/team/group/CCSS/main/ccss.c?view=diff&rev=224445&r1=224444&r2=224445
==============================================================================
--- team/group/CCSS/main/ccss.c (original)
+++ team/group/CCSS/main/ccss.c Sun Oct 18 16:40:53 2009
@@ -1470,6 +1470,13 @@
 	struct dialed_cc_interfaces *cc_interfaces;
 	struct ast_control_cc_payload *cc_data = frame_data;
 
+	/* XXX There have been discussions that indicate that hacking up the channel name is not
+	 * the ideal way to determine the device name of the dialed interface since ISDN channels
+	 * in particular can potentially change names, and their names are based on the B channel
+	 * chosen, not the device dialed. Furthermore, an ISDN channel has the potential to change
+	 * names. The correct way to handle this is to make the dialed device name part of the
+	 * payload for the CC control frame.
+	 */
 	ast_copy_string(device_name, outbound->name, sizeof(device_name));
 	if ((dash = strrchr(device_name, '-'))) {
 		*dash = '\0';