[asterisk-commits] file: tag 1.6.0.19 r231606 - /tags/1.6.0.19/channels/chan_sip.c

[SVN commits to the Asterisk project]

Author: file
Date: Mon Nov 30 14:51:12 2009
New Revision: 231606

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=231606
Log:
When receiving SDP that matches the version of the last one do not treat it as a fatal error.

(closes issue #16238)
Reported by: seandarcy 

Modified:
    tags/1.6.0.19/channels/chan_sip.c

Modified: tags/1.6.0.19/channels/chan_sip.c
URL: http://svnview.digium.com/svn/asterisk/tags/1.6.0.19/channels/chan_sip.c?view=diff&rev=231606&r1=231605&r2=231606
==============================================================================
--- tags/1.6.0.19/channels/chan_sip.c (original)
+++ tags/1.6.0.19/channels/chan_sip.c Mon Nov 30 14:51:12 2009
@@ -6998,8 +6998,11 @@
 		int processed = FALSE;
 		switch (type) {
 		case 'o':
+			/* If we end up receiving SDP that doesn't actually modify the session we don't want to treat this as a fatal
+			 * error. We just want to ignore the SDP and let the rest of the packet be handled as normal.
+			 */
 			if (!process_sdp_o(value, p))
-				return -1;
+				return (p->session_modify == FALSE) ? 0 : -1;
 			break;
 		case 'c':
 			if (process_sdp_c(value, &sessionhp)) {
@@ -7448,6 +7451,8 @@
 	change media session and increment its own version number in answer
 	SDP in this case. */
 
+	p->session_modify = TRUE;
+
 	if (ast_strlen_zero(o)) {
 		ast_log(LOG_WARNING, "SDP syntax error. SDP without an o= line\n");
 		return FALSE;
@@ -7496,11 +7501,9 @@
 	    (p->sessionversion_remote < 0) ||
 	    (p->sessionversion_remote < rua_version)) {
 		p->sessionversion_remote = rua_version;
-		p->session_modify = TRUE;
 	} else {
 		if (p->t38.state == T38_LOCAL_REINVITE) {
 			p->sessionversion_remote = rua_version;
-			p->session_modify = TRUE;
 			ast_log(LOG_WARNING, "Call %s responded to our T.38 reinvite without changing SDP version; 'ignoresdpversion' should be set for this peer.\n", p->callid);
 		} else {
 			p->session_modify = FALSE;