[asterisk-commits] mmichelson: branch mmichelson/digit_manipulation r197195 - /team/mmichelson/d...

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Wed May 27 14:10:50 2009
New Revision: 197195

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=197195
Log:
Add a couple of comments explaining why we aren't locking channels in certain places.


Modified:
    team/mmichelson/digit_manipulation/channels/chan_sip.c

Modified: team/mmichelson/digit_manipulation/channels/chan_sip.c
URL: http://svn.asterisk.org/svn-view/asterisk/team/mmichelson/digit_manipulation/channels/chan_sip.c?view=diff&rev=197195&r1=197194&r2=197195
==============================================================================
--- team/mmichelson/digit_manipulation/channels/chan_sip.c (original)
+++ team/mmichelson/digit_manipulation/channels/chan_sip.c Wed May 27 14:10:50 2009
@@ -20425,7 +20425,9 @@
 		target.chan1->uniqueid);
 	ast_party_connected_line_init(&connected_to_transferee);
 	ast_party_connected_line_init(&connected_to_target);
+	/* No need to lock current->chan1 here since it was locked in sipsock_read */
 	ast_party_connected_line_copy(&connected_to_transferee, &current->chan1->connected);
+	/* No need to lock target.chan1 here since it was locked in get_sip_pvt_byid_locked */
 	ast_party_connected_line_copy(&connected_to_target, &target.chan1->connected);
 	connected_to_target.source = connected_to_transferee.source = AST_CONNECTED_LINE_UPDATE_SOURCE_TRANSFER;
 	res = attempt_transfer(current, &target);