[asterisk-commits] lmadsen: tag 1.4.25-rc1 r194218 - /tags/1.4.25-rc1/
SVN commits to the Asterisk project
asterisk-commits at lists.digium.com
Wed May 13 09:17:44 CDT 2009
Author: lmadsen
Date: Wed May 13 09:17:40 2009
New Revision: 194218
URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=194218
Log:
Importing files for 1.4.25-rc1 release.
Added:
tags/1.4.25-rc1/.lastclean (with props)
tags/1.4.25-rc1/.version (with props)
tags/1.4.25-rc1/ChangeLog (with props)
Added: tags/1.4.25-rc1/.lastclean
URL: http://svn.asterisk.org/svn-view/asterisk/tags/1.4.25-rc1/.lastclean?view=auto&rev=194218
==============================================================================
--- tags/1.4.25-rc1/.lastclean (added)
+++ tags/1.4.25-rc1/.lastclean Wed May 13 09:17:40 2009
@@ -1,0 +1,1 @@
+33
Propchange: tags/1.4.25-rc1/.lastclean
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: tags/1.4.25-rc1/.lastclean
------------------------------------------------------------------------------
svn:keywords = none
Propchange: tags/1.4.25-rc1/.lastclean
------------------------------------------------------------------------------
svn:mime-type = text/plain
Added: tags/1.4.25-rc1/.version
URL: http://svn.asterisk.org/svn-view/asterisk/tags/1.4.25-rc1/.version?view=auto&rev=194218
==============================================================================
--- tags/1.4.25-rc1/.version (added)
+++ tags/1.4.25-rc1/.version Wed May 13 09:17:40 2009
@@ -1,0 +1,1 @@
+1.4.25-rc1
Propchange: tags/1.4.25-rc1/.version
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: tags/1.4.25-rc1/.version
------------------------------------------------------------------------------
svn:keywords = none
Propchange: tags/1.4.25-rc1/.version
------------------------------------------------------------------------------
svn:mime-type = text/plain
Added: tags/1.4.25-rc1/ChangeLog
URL: http://svn.asterisk.org/svn-view/asterisk/tags/1.4.25-rc1/ChangeLog?view=auto&rev=194218
==============================================================================
--- tags/1.4.25-rc1/ChangeLog (added)
+++ tags/1.4.25-rc1/ChangeLog Wed May 13 09:17:40 2009
@@ -1,0 +1,24373 @@
+2009-05-13 Leif Madsen <lmadsen at digium.com>
+
+ * Release Asterisk 1.4.25-rc1
+
+2009-05-13 13:38 +0000 [r194208] Joshua Colp <jcolp at digium.com>
+
+ * main/rtp.c: Fix RFC2833 issues with DTMF getting duplicated and
+ with duration wrapping over. (closes issue #14815) Reported by:
+ geoff2010 Patches: v1-14815.patch uploaded by dimas (license 88)
+ Tested by: geoff2010, file, dimas, ZX81, moliveras (closes issue
+ #14460) Reported by: moliveras Tested by: moliveras
+
+2009-05-13 00:52 +0000 [r194137] Tilghman Lesher <tlesher at digium.com>
+
+ * main/pbx.c: Fix logic for how to proceed with a single digit
+ extension. (closes issue #15091) Reported by: andrew Patches:
+ 20090512__issue15091.diff.txt uploaded by tilghman (license 14)
+ Tested by: andrew
+
+2009-05-12 22:15 +0000 [r194028] Matthew Nicholson <mnicholson at digium.com>
+
+ * apps/app_queue.c: This change modifies app_queue to properly
+ generate CDR records in failure situations. This involves setting
+ a proper cdr disposition coresponding to the given failure
+ condition and ensuring the proper information is stored in the
+ cdr record. (closes issue #13691) Reported by: dferrer Tested by:
+ mnicholson (closes issue #13637) Reported by: atis Tested by:
+ atis
+
+2009-05-12 20:39 +0000 [r193955] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_voicemail.c: Avoid initializing routines if the
+ authentication fails. Fixes a crash (RR) issue. (closes issue
+ #14508) Reported by: tiziano Patches:
+ 20090221_2_wrongmailbox.diff.txt uploaded by tiziano (license
+ 377)
+
+2009-05-12 18:18 +0000 [r193880] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_sip.c: Set the invitestate to INV_CANCELLED only if
+ we are actually sending a SIP CANCEL. The problem was that the
+ hangup code was setting the invitestate too early. The result of
+ this was that we would always send a CANCEL request, even if it
+ was not an appropriate time to do so (e.g. we have not yet
+ received a provisional response for our INVITE). Note that this
+ same fix had been applied to trunk and the 1.6.X branches
+ starting with revision 155467. This is why you will see this
+ revision being blocked from those places. AST-216
+
+2009-05-11 22:48 +0000 [r193755] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_voicemail.c: Move 300 bytes around on the stack, to make
+ more room for an extension buffer. This allows more concurrent
+ extensions to be copied for a single voicemail, without creating
+ a possibility of upsetting existing users, where a dialplan could
+ run out of stack space where it had run fine before.
+ Alternatively, we could have allocated off the heap, but that is
+ a larger change and would have increased the chance for
+ instability introduced by this change. This is really solved
+ starting in 1.6.0.11, as the use of an ast_str buffer allows an
+ unlimited number of extensions (up to available memory). We
+ additionally create a new warning message when the buffer length
+ is exceeded, permitting administrators to see an issue after the
+ fact, whereas previously the list was silently truncated. (closes
+ issue #14739) Reported by: p_lindheimer Patches:
+ 20090417__bug14739.diff.txt uploaded by tilghman (license 14)
+ Tested by: p_lindheimer
+
+2009-05-11 19:09 +0000 [r193613] Richard Mudgett <rmudgett at digium.com>
+
+ * channels/chan_misdn.c: Sent wrong message to clear a call we
+ started if the other end has not responed yet. In the state
+ MISDN_CALLING (i.e. SETUP was sent but no answer has arrived
+ yet), it is not allowed to clear the call with RELEASE_COMPLETE.
+ It must be cleared with DISCONNECT. A RELEASE_COMPLETE is only
+ allowed as an answer to a SETUP. (See Q.931 ch. 5.3.2, 5.3.2.a,
+ 5.3.2.b) Patches: chan-misdn-ccstate7.patch uploaded by customer.
+ JIRA ABE-1862
+
+2009-05-11 17:35 +0000 [r193544] Leif Madsen <lmadsen at digium.com>
+
+ * funcs/func_channel.c: Document CHANNEL(transfercapability) in CLI
+ documentation. (issue #15073) Reported by: pkempgen Patches:
+ 20090511__issue15073.diff.txt uploaded by tilghman (license 14)
+
+2009-05-08 21:01 +0000 [r193391] Matthew Nicholson <mnicholson at digium.com>
+
+ * main/channel.c: Set the proper disposition on originated calls.
+ (closes issue #14167) Reported by: jpt Patches:
+ call-file-missing-cdr2.diff uploaded by mnicholson (license 96)
+ Tested by: dlotina, rmartinez, mnicholson
+
+2009-05-08 14:51 +0000 [r193262] David Vossel <dvossel at digium.com>
+
+ * channels/misdn_config.c: "misdn show config" segfaults asterisk,
+ if no MSN lists (closes issue #14976) Reported by: alecdavis
+ Patches: misdn_config.diff.txt uploaded by alecdavis (license
+ 585) Tested by: alecdavis, FabienToune
+
+2009-05-08 14:03 +0000 [r193193] Kevin P. Fleming <kpfleming at digium.com>
+
+ * configs/logger.conf.sample, main/logger.c: Make absolute paths
+ for logger channels work properly (Note: This is not a new
+ feature, it was previously undocumented and broken.) The Asterisk
+ logger has a feature to support absolute pathnames for logger
+ channels, but the code implementing the feature was broken. This
+ has been fixed, and the absolute path feature is now documented
+ in the sample logger.conf.
+
+2009-05-07 23:41 +0000 [r193119] Tilghman Lesher <tlesher at digium.com>
+
+ * main/pbx.c: Fix Background within a Macro for FreePBX. If the
+ single digit DTMF is an extension in the specified context, then
+ go there and signal no DTMF. Otherwise, we should exit with that
+ DTMF. If we're in Macro, we'll exit and seek that DTMF as the
+ beginning of an extension in the Macro's calling context. If
+ we're not in Macro, then we'll simply seek that extension in the
+ calling context. Previously, someone complained about the
+ behavior as it related to the interior of a Gosub routine, and
+ the fix (#14011) inadvertently broke FreePBX (#14940). This
+ change should fix both of these situations, but with the possible
+ incompatibility that if a single digit extension does not exist
+ (but a longer extension COULD have matched), it would have
+ previously gone immediately to the "i" extension, but will now
+ need to wait for a timeout. (closes issue #14940) Reported by:
+ p_lindheimer Patches: 20090420__bug14940.diff.txt uploaded by
+ tilghman (license 14) Tested by: p_lindheimer
+
+2009-05-07 22:17 +0000 [r193050] Richard Mudgett <rmudgett at digium.com>
+
+ * channels/chan_misdn.c: Give a more helpful message when an
+ incoming call's dialed extension does not match. Added the dialed
+ extension and context to the chan_misdn messages warning that the
+ dialed number cannot be matched in the dialplan.
+
+2009-05-07 16:29 +0000 [r192932] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_sip.c: Eliminate repetition of fullcontact during
+ reconstruction. If the fullcontact field appears in both the
+ sippeers and the sipregs table, then during reconstruction of the
+ field, it will otherwise be doubled. (closes issue #14754)
+ Reported by: Alexei Gradinari Patches:
+ 20090506__bug14754.diff.txt uploaded by tilghman (license 14)
+ Tested by: lmadsen
+
+2009-05-06 22:15 +0000 [r192858] Jeff Peeler <jpeeler at digium.com>
+
+ * res/res_features.c: Make ParkedCall application stop execution of
+ the dialplan after hang up Just changed park_exec to always
+ return non-zero. I really wasn't entirely sure at first if this
+ was a bug. Decided it was since it would be surprising when not
+ using ParkedCall in the dialplan to hang up and have dialplan
+ execution continue. (closes issue #14555) Reported by:
+ francesco_r
+
+2009-05-06 13:30 +0000 [r192633] Joshua Colp <jcolp at digium.com>
+
+ * channels/chan_sip.c: Update some old logic to stop both begin and
+ end DTMF frames from reaching the core if rfc2833 is not enabled.
+ (closes issue #15036) Reported by: dimas Patches: v1-15036.patch
+ uploaded by dimas (license 88)
+
+2009-05-05 19:56 +0000 [r192524] Sean Bright <sean.bright at gmail.com>
+
+ * static-http/astman.js: Fix Javascript error when using astman.js
+ in Internet Explorer. Internet Explorer (tested with 7.0) does
+ not like trailing commas on constructs like object initializers,
+ so get rid of them to avoid some errors. (closes issue #15026)
+ Reported by: rajnishgiri Patches: bug15026.patch uploaded by
+ seanbright (license 71) Tested by: seanbright
+
+2009-05-05 18:22 +0000 [r192429-192454] Joshua Colp <jcolp at digium.com>
+
+ * res/res_features.c: Fix an incorrect assumption that certain
+ values on the channel will always exist when they may not. The
+ CDR code involved with bridges wrongly assumed that the currently
+ executing application and data values will always exist. It is
+ possible for this to be false when call forwarding is involved.
+ (closes issue #14984) Reported by: gincantalupo
+
+ * apps/app_followme.c: Fix a bug where the followme application
+ would continue trying numbers after the caller hung up. (closes
+ issue #13624) Reported by: sgenyuk
+
+2009-05-04 22:37 +0000 [r192213] David Vossel <dvossel at digium.com>
+
+ * channels/chan_iax2.c: global mohinterpret setting is ignored
+ mohinterpret and mohsuggest global variables were not copied over
+ during build_users and build_peers. (closes issue #14728)
+ Reported by: dimas Patches: v1-14728.patch uploaded by dimas
+ (license 88) Tested by: dimas, dvossel
+
+2009-05-02 18:48 +0000 [r191628-191778] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_voicemail.c: Fix a bug which resulted from the Hebrew
+ voicemail commit. This fixes a case where a certain message could
+ get played twice. (closes issue #13155) Reported by:
+ greenfieldtech Patches: app_voicemail.c.multi-lang-patch uploaded
+ by greenfieldtech (license 369) Tested by: greenfieldtech
+
+ * apps/app_chanspy.c: Kevin has informed me that thi sort of thing
+ is not necessary.
+
+ * apps/app_chanspy.c: Move static buffers to outside for loops in
+ app_chanspy. Similar to seanbright's commit 191422, this moves
+ some static buffers to be defined outside of for loops since it
+ is undefined if memory will be re-used or if the stack will grow
+ with each iteration of the loop.
+
+2009-05-01 20:00 +0000 [r191559] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_sip.c: SIP Response 410 maps to cause code 22 (or
+ 23), not 1. (closes issue #14993) Reported by: BigJimmy Patches:
+ causepatch uploaded by BigJimmy (license 371)
+
+2009-05-01 17:40 +0000 [r191488] Jeff Peeler <jpeeler at digium.com>
+
+ * main/channel.c: Fix DTMF not being sent to other side after a
+ partial feature match This fixes a regression from commit 176701.
+ The issue was that ast_generic_bridge never exited after the
+ feature digit timeout had elapsed, which prevented the queued
+ DTMF from being sent to the other side. This issue was reported
+ to me directly.
+
+2009-05-01 15:42 +0000 [r191422] Sean Bright <sean.bright at gmail.com>
+
+ * apps/app_queue.c: Move the defintion of the a couple arrays out
+ of loops. According to Kevin, it is unspecified as to whether a
+ variable defined inside a block is allocated once by the compiler
+ or for each pass through the block (loops being the only
+ interesting case), so just define these before we get into our
+ loop to be sure.
+
+2009-04-29 23:10 +0000 [r191220] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/h323/ast_h323.cxx, channels/chan_h323.c: Allow H.323 to
+ compile with FDLEAK checking enabled.
+
+2009-04-29 18:07 +0000 [r191096] David Brooks <dbrooks at digium.com>
+
+ * pbx/pbx_config.c: Patch to fix tab-completion crash on "remove
+ extension" This patch simply removes some old code back before
+ Asterisk used editline. This fixes the crash that occurred when
+ tab-completing "remove extension". (closes issue #14689) Reported
+ by: isaacgal
+
+2009-04-29 15:23 +0000 [r191041] Sean Bright <sean.bright at gmail.com>
+
+ * apps/app_queue.c: Fix a crash in app_queue with very long member
+ lists. A user reported via #asterisk that with very long lists of
+ members, a crash occurs in ast_strdupa, so just use a single
+ buffer and ast_copy_string instead of stack allocating copys of
+ each interface name.
+
+2009-04-27 19:29 +0000 [r190721] Kevin P. Fleming <kpfleming at digium.com>
+
+ * configure, include/asterisk/autoconfig.h.in: Fix 'inconsistent
+ line endings' when autoconf 2.63 is used Attempt to make
+ configure script regeneration 'safe' using autoconf 2.63, which
+ embeds a bare CR into the script, thus making Subversion complain
+ about inconsistent line endings This commit changes the MIME type
+ of the configure script to be 'binary' thus making Subversion no
+ longer inspect line endings, and as a bonus 'svn diff' will no
+ longer try to generate diff output for it, which is not generally
+ useful anyway.
+
+2009-04-27 19:03 +0000 [r190661-190662] Russell Bryant <russell at digium.com>
+
+ * res/res_smdi.c: Fix a typo from 190661.
+
+ * res/res_smdi.c: Resolve a crash in res_smdi when used with
+ chan_dahdi. When chan_dahdi goes to get an SMDI message, it
+ provides no search criteria. It just grabs the next message that
+ arrives. This code was written with the SMDI dialplan functions
+ in mind, since that is now the preferred method of using SMDI.
+ However, this broke support of it being used from chan_dahdi.
+ (closes AST-212)
+
+2009-04-23 21:07 +0000 [r190356] Russell Bryant <russell at digium.com>
+
+ * channels/chan_sip.c: Remove a bogus ast_channel_unlock().
+
+2009-04-23 19:13 +0000 [r190286] Joshua Colp <jcolp at digium.com>
+
+ * channels/chan_local.c: Fix a bug in chan_local glare hangup
+ detection. If both sides of a Local channel were hung up at
+ around the same time it was possible for one thread to destroy
+ the local private structure and have the other thread immediately
+ try to remove the already freed structure from the local channel
+ list.
+
+2009-04-23 10:07 +0000 [r190187] Olle Johansson <oej at edvina.net>
+
+ * include/asterisk/lock.h: unistd.h is required for usleep() on
+ Darwin. It will not hurt to include it always on other platforms
+ either.
+
+2009-04-22 21:35 +0000 [r190092] Tilghman Lesher <tlesher at digium.com>
+
+ * configure, include/asterisk/autoconfig.h.in, configure.ac,
+ include/asterisk/lock.h: Detect availability of
+ pthread_rwlock_timedwrlock() before using it. (closes issue
+ #14930) Reported by: tilghman Patches:
+ 20090420__bug14930.diff.txt uploaded by tilghman (license 14)
+ Tested by: mvanbaak, tilghman
+
+2009-04-22 19:20 +0000 [r189991] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/h323/ast_h323.cxx, channels/chan_h323.c,
+ channels/h323/chan_h323.h: Make chan_h323 respect packetization
+ settings Previously, packetization settings were ignored and now
+ they are not. A new config option 'autoframing' has been added to
+ mirror the way chan_sip handles it. Turning on the autoframing
+ option (available both as a global option or per peer) overrides
+ the local settings with the remote packetization settings.
+ Testing was performed with varying packetization levels with the
+ following codecs: ulaw, alaw, gsm, and g729. (closes issue
+ #12415) Reported by: pj Patches:
+ 2009012200_h323packetization.diff.txt uploaded by mvanbaak
+ (license 7), modified by me
+
+2009-04-22 14:29 +0000 [r189849] Michiel van Baak <michiel at vanbaak.info>
+
+ * contrib/scripts/get_ilbc_source.sh: replace sed with tr to remove
+ \r from downloaded file On some systems, sed does not recognize
+ \r in the pattern the way it was used here. Use tr instead
+ because this works the same across systems. (closes issue #14936)
+ Reported by: leobrown Patches: 2009042201_14936.diff.txt uploaded
+ by mvanbaak (license 7) Tested by: leobrown, mvanbaak
+
+2009-04-21 15:52 +0000 [r189601-189664] Doug Bailey <dbailey at digium.com>
+
+ * utils/muted.c: Remove daemon call on systems that do not support
+ forking.
+
+ * main/config.c, configure, include/asterisk/autoconfig.h.in,
+ include/asterisk/compat.h, configure.ac: Add check in configure
+ script to check for GLOB_NOMAGIC and GLOB_BRACE in glob.h This
+ allows config.c to compile when linked against uclibc that does
+ not support these parameters
+
+2009-04-20 22:02 +0000 [r189537] Tilghman Lesher <tlesher at digium.com>
+
+ * funcs/func_odbc.c, funcs/func_strings.c: Add a workaround for
+ func_odbc/ARRAY() for problems that occur with certain special
+ characters. In certain cases, due to the way Set() works in 1.4,
+ values may not get set properly. This is a workaround for 1.4
+ only that corrects for these issues, without making func_odbc
+ more difficult to use properly. (closes issue #14614) Reported
+ by: wdoekes Patches: 20090309__bug14614__2.diff.txt uploaded by
+ tilghman (license 14)
+ double_set_unescape_workaround_for_func_odbc.osso-and-tilghman-1.diff
+ uploaded by wdoekes (license 717) Tested by: wdoekes, tilghman
+
+2009-04-20 21:10 +0000 [r189463-189465] Terry Wilson <twilson at digium.com>
+
+ * apps/app_dial.c: Update CDR appropriately when
+ AST_CAUSE_NO_ANSWER is set
+
+ * apps/app_dial.c: Don't treat a NOANSWER like a CHANUNAVAIL
+
+2009-04-20 20:58 +0000 [r189462] Sean Bright <sean.bright at gmail.com>
+
+ * pbx/ael/ael.tab.c, pbx/ael/ael.y: Properly handle @s within hints
+ in AEL. AEL was not handling the case of a device hint containing
+ an @ symbol, which caused parking hints (e.g.
+ hint(park:exten at context)) to error out the parser. This patch
+ makes AEL treat the @ the same way it treats colon and ampersand
+ now, meaning the characters are included in verbatim. (closes
+ issue #14941) Reported by: bpgoldsb Patches: bug14941.patch
+ uploaded by seanbright (license 71) Tested by: bpgoldsb
+
+2009-04-20 19:10 +0000 [r189391] Doug Bailey <dbailey at digium.com>
+
+ * main/manager.c, main/db1-ast/recno/rec_open.c,
+ channels/chan_iax2.c: Clean up problem with manager
+ implementation of mmap where it was not testing against
+ MAP_FAILED response. Got rid of shadowed variable used in
+ processign the mmap results. Change test of mmap results to
+ compare against MAP_FAILED
+
+2009-04-20 14:04 +0000 [r189277] Mark Michelson <mmichelson at digium.com>
+
+ * main/channel.c: Move the check for chan->fdno == -1 to after the
+ zombie/hangup check. Many users were finding that their hung up
+ channels were staying up and causing 100% CPU usage. (issue
+ #14723) Reported by: seadweller Patches: 14723_1-4-tip.patch
+ uploaded by mmichelson (license 60) Tested by: falves11, bamby
+
+2009-04-18 01:27 +0000 [r189203] David Vossel <dvossel at digium.com>
+
+ * channels/chan_agent.c: Fixed autologoff in agents.conf not
+ working when agent logs in via AgentLogin app An agent logs in by
+ calling an extension that calls the AgentLogin app. In
+ agents.conf ackcall=always is set, so when they get a call they
+ have the choice to either acknowledge it or ignore it.
+ autologoff=10 is set as well, so if the agent ignores the call
+ over 10sec one may assume that the agent should be logged out
+ (and in this case hungup on as well), but this was not happening.
+ (closes issue #14091) Reported by: evandro Patches:
+ autologoff.diff uploaded by dvossel (license 671) Review:
+ http://reviewboard.digium.com/r/225/
+
+2009-04-17 21:27 +0000 [r189134] Richard Mudgett <rmudgett at digium.com>
+
+ * channels/misdn/isdn_lib.c: Modifed/added some debug messages.
+ JIRA ABE-1835
+
+2009-04-17 15:43 +0000 [r189009] Matthew Nicholson <mnicholson at digium.com>
+
+ * main/pbx.c: Make Busy() application set the CDR disposition to
+ BUSY. (closes issue #14306) Reported by: cristiandimache
+
+2009-04-17 14:41 +0000 [r188937-188946] Joshua Colp <jcolp at digium.com>
+
+ * channels/chan_sip.c: Fix a bug where a value used to create the
+ channel name was bogus. This commit fixes the scenario where an
+ incoming call is authenticated using a peer entry. Previously the
+ channel name was created using either the username setting from
+ the sip.conf entry or the IP address that the call came from. Now
+ the channel name will be created using the peer name itself. This
+ commit will not change the way the channel name is generated for
+ users or friends. (closes issue #14256) Reported by: Nick_Lewis
+ Patches: chan_sip.c-chname.patch uploaded by Nick (license 657)
+ Tested by: Nick_Lewis, file
+
+ * channels/chan_dahdi.c: Fix a situation where the DAHDI channel
+ private structure lock was not unlocked when it should have been.
+ (issue AST-210)
+
+2009-04-16 21:41 +0000 [r188835] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_sip.c: Only update realtime, if global option
+ rtupdate != false (closes issue #14885) Reported by: deepesh
+ Patches: 20090413__bug14885.diff.txt uploaded by tilghman
+ (license 14) Tested by: deepesh
+
+2009-04-16 21:37 +0000 [r188833] Richard Mudgett <rmudgett at digium.com>
+
+ * channels/chan_misdn.c: Only disable mISDN DSP if Asterisk DSP is
+ enabled. Leave jitter setting alone. JIRA ABE-1835
+
+2009-04-16 21:02 +0000 [r188773] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_voicemail.c: Umask should not be exported into global
+ namespace. (closes issue #14912) Reported by: jcapp
+
+2009-04-15 22:08 +0000 [r188646] David Vossel <dvossel at digium.com>
+
+ * channels/chan_dahdi.c: National prefix inserted even when caller
+ ID not available When the caller ID is restricted, the expected
+ behavior is for the caller id to be blank. In chan_dahdi, the
+ national prefix is placed onto the callers number even if its
+ restricted (empty) causing the caller id to be the national
+ prefix rather than blank. (closes issue #13207) Reported by:
+ shawkris Patches: national_prefix.diff uploaded by dvossel
+ (license 671) Review: http://reviewboard.digium.com/r/220/
+
+2009-04-15 20:04 +0000 [r188582] Mark Michelson <mmichelson at digium.com>
+
+ * main/file.c: Update ast_readvideo_callback to match
+ ast_readaudio_callback. This fixes potential refcount errors that
+ may occur on ast_filestreams. AST-208
+
+2009-04-14 15:02 +0000 [r188287] David Vossel <dvossel at digium.com>
+
+ * main/audiohook.c: audio_audiohook_write_list() does not correctly
+ update sample size after ast_translate.
+ audio_audiohook_write_list() does not take into account that the
+ sample size may change after translation depending on if the
+ original frame is is 8khz or 16khz. While no 16kz codecs are
+ supported in 1.4 at the moment, this will save headaches in the
+ future if they ever are. the sample size is now updated after
+ translating to reflect this possibility. Thanks to jcolp and
+ mmichelson for helping me work this out. (issue AST-197)
+
+2009-04-13 23:04 +0000 [r188149] Tilghman Lesher <tlesher at digium.com>
+
+ * res/res_odbc.c: If fileconfig limit exceeds our maximum, then set
+ the limit to the maximum. (Closes issue #14888) Reported by:
+ falves11
+
+2009-04-10 22:16 +0000 [r187962] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/Makefile: Fix module embedding for chan_h323. Include
+ libchanh323.a in the modules.link file so that all the symbols
+ can be resolved at link time. (closes issue #11966) Reported by:
+ dome
+
+2009-04-10 19:26 +0000 [r187865] Russell Bryant <russell at digium.com>
+
+ * channels/chan_dahdi.c: Support "signaling" in addition to
+ "signalling". The sample configuration file has references to
+ both spellings.
+
+2009-04-10 17:28 +0000 [r187763] Tilghman Lesher <tlesher at digium.com>
+
+ * contrib/scripts/realtime_pgsql.sql,
+ contrib/scripts/sip-friends.sql: Add lastms column to the
+ contributed table designs
+
+2009-04-09 18:51 +0000 [r187484] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_sip.c: Handle a SIP race condition (reinvite before
+ an ACK) properly. RFC 5047 explains the proper course of action
+ to take if a reINVITE is received before the ACK from a previous
+ invite transaction. What we are to do is to treat the reINVITE as
+ if it were both an ACK and a reINVITE and process it normally.
+ Later, when we receive the ACK we had been expecting, we will
+ ignore it since its CSeq is less than the current iseqno of the
+ sip_pvt representing this dialog. (closes issue #13849) Reported
+ by: klaus3000 Patches: 13849_v2.patch uploaded by mmichelson
+ (license 60) Tested by: mmichelson, klaus3000
+
+2009-04-09 18:39 +0000 [r187209-187482] Tilghman Lesher <tlesher at digium.com>
+
+ * include/asterisk/lock.h: Oops, typo
+
+ * main/manager.c, include/asterisk/lock.h: Race condition between
+ ast_cli_command() and 'module unload' could cause a deadlock. Add
+ lock timeouts to avoid this potential deadlock. (closes issue
+ #14705) Reported by: jamessan Patches:
+ 20090320__bug14705.diff.txt uploaded by tilghman (license 14)
+ Tested by: jamessan
+
+ * channels/chan_sip.c, apps/app_sendtext.c: Permit zero-length text
+ messages in SIP. (Related to an issue posted to the -users list,
+ subject "AEL2, BASE64_DECODE and hexadecimal")
+
+ * main/astfd.c (added): Oops, missed this file in the last commit.
+
+ * main/asterisk.c, agi/Makefile, build_tools/cflags.xml,
+ utils/Makefile, include/asterisk.h, main/Makefile, main/file.c:
+ Add debugging mode for diagnosing file descriptor leaks. (Related
+ to issue #14625)
+
+ * main/manager.c: Backport resolution for file descriptor leak in
+ 1.6.0 to 1.4. This fixes short reads in http manager sessions,
+ such as those done by the ast-gui branch. (Fixes AST-198)
+
+2009-04-08 19:16 +0000 [r186832-187135] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_dial.c: Fix a crash due to too few arguments to
+ RetryDial. (closes issue #14852) Reported by: junky Patches:
+ retry_fix.diff uploaded by junky (license 177)
+
+ * res/res_musiconhold.c: Fix a small logical error when loading moh
+ classes. We were unconditionally incrementing the number of
+ mohclasses registered. However, we should actually only increment
+ if the call to moh_register was successful. While this probably
+ has never caused problems, I noticed it and decided to fix it
+ anyway.
+
+ * main/channel.c: Make a couple of changes with regards to a new
+ message printed in ast_read(). "ast_read() called with no
+ recorded file descriptor" is a new message added after a bug was
+ discovered. Unfortunately, it seems there are a bunch of places
+ that potentially make such calls to ast_read() and trigger this
+ error message to be displayed. This commit does two things to
+ help to make this message appear less. First, the message has
+ been downgraded to a debug level message if dev mode is not
+ enabled. The message means a lot more to developers than it does
+ to end users, and so developers should take an effort to be sure
+ to call ast_read only when a channel is ready to be read from.
+ However, since this doesn't actually cause an error in operation
+ and is not something a user can easily fix, we should not spam
+ their console with these messages. Second, the message has been
+ moved to after the check for any pending masquerades. ast_read()
+ being called with no recorded file descriptor should not
+ interfere with a masquerade taking place. This could be seen as a
+ simple way of resolving issue #14723. However, I still want to
+ try to clear out the existing ways of triggering this message,
+ since I feel that would be a better resolution for the issue.
+
+ * formats/format_wav.c, formats/format_wav_gsm.c: Fix a few typos
+ of the word "frequency." (closes issue #14842) Reported by:
+ jvandal Patches: frequency-typo.diff uploaded by jvandal (license
+ 413)
+
+ * main/channel.c: Set the AST_FEATURE_WARNING_ACTIVE flag when a
+ p2p bridge returns AST_BRIDGE_RETRY. Without this flag set,
+ warning sounds will not be properly played to either party of the
+ bridge. (closes issue #14845) Reported by: adomjan
+
+2009-04-07 22:16 +0000 [r186775] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_macro.c: Fix Macro documentation to match current (and
+ intended) behavior. (See -dev mailing list)
+
+2009-04-07 20:43 +0000 [r186719] Mark Michelson <mmichelson at digium.com>
+
+ * main/manager.c: Ensure that \r\n is printed after the ActionID in
+ an OriginateResponse. (closes issue #14847) Reported by: kobaz
+
+2009-04-06 13:54 +0000 [r186565] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_voicemail.c: Revert commit 186445 because it causes the
+ build to fail when IMAP_STORAGE is used.
+
+2009-04-03 20:19 +0000 [r186458] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: Fix a bug where DAHDI/Zaptel channels
+ would not properly switch formats when requested Don't offer
+ AST_FORMAT_SLINEAR on DAHDI/Zaptel channels... while it could
+ provide a slight performance benefit, the translation core in
+ Asterisk has some flaws when a channel driver offers multiple raw
+ formats. this fix is much simpler than fixing the translation
+ core to solve that issue (although that will be done later).
+
+2009-04-03 19:56 +0000 [r186415-186445] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_voicemail.c: Found a conflict in the last commit, due to
+ multiple targets
+
+ * apps/app_voicemail.c, configs/voicemail.conf.sample: Distinguish
+ in a sent email between simple sends and forwards. (closes issue
+ #11678) Reported by: jamessan Patches:
+ 20090330__bug11678.diff.txt uploaded by tilghman (license 14)
+ Tested by: tilghman, lmadsen
+
+2009-04-03 15:48 +0000 [r186320] Joshua Colp <jcolp at digium.com>
+
+ * include/asterisk/crypto.h: Fix a problem with the crypto variable
+ definitions not actually being defined properly. (closes issue
+ #14804) Reported by: jvandal
+
+2009-04-03 01:57 +0000 [r186229] Russell Bryant <russell at digium.com>
+
+ * cdr/cdr_radius.c: Fix a memory leak in cdr_radius. I came across
+ this while doing some testing of my ast_channel_ao2 branch. After
+ running a test overnight that generated over 5 million calls,
+ Asterisk had taken up about 1 GB of my system memory. So, I
+ re-ran the test with MALLOC_DEBUG turned on. However, it showed
+ no leaks in Asterisk during the test, even though Asterisk was
+ still consuming it somehow. Instead, I turned to valgrind, which
+ when run with --leak-check=full, told me exactly where the leak
+ came from, which was from allocations inside the radiusclient-ng
+ library. This explains why MALLOC_DEBUG did not report it. After
+ a bit of analysis, I found that we were leaking a little bit of
+ memory every time a CDR record was passed to cdr_radius. I don't
+ actually have a radius server set up to receive CDR records.
+ However, I always have my development systems compile and install
+ all modules. In addition to making sure there are not build
+ errors across modules, always loading modules helps find bugs
+ like this, too, so it is strongly recommend for all developers.
+
+2009-04-02 21:55 +0000 [r186174] Mark Michelson <mmichelson at digium.com>
+
+ * configs/features.conf.sample: Fix instructions in one-step
+ parking comment to make more sense. Changed a capital K to a
+ lowercase k.
+
+2009-04-02 17:21 +0000 [r186081] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: ensure that the buffer passed to
+ DAHDI_SET_BUFINFO is fully initialized
+
+2009-04-02 17:09 +0000 [r186057-186059] Tilghman Lesher <tlesher at digium.com>
+
+ * /, channels/chan_sip.c, configs/sip.conf.sample: Merged revisions
+ 186056 via svnmerge from
+ https://origsvn.digium.com/svn/asterisk/branches/1.2 ........
+ r186056 | tilghman | 2009-04-02 12:02:18 -0500 (Thu, 02 Apr 2009)
+ | 2 lines Fix for AST-2009-003 ........
+
+ * channels/chan_sip.c: Avoid multiple warning messages in SIP, due
+ to this column not existing
+
+2009-04-02 13:43 +0000 [r185952] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: the DAHDI_GETCONF, DAHDI_SETCONF and
+ DAHDI_GET_PARAMS ioctls were recently corrected to show that they
+ do, in fact, read data from userspace as part of their work. due
+ to this fix, valgrind now reports a number of cases where
+ chan_dahdi passed an uninitialized (or partially) buffer to these
+ ioctls, which could lead to unexpected behavior. this patch
+ corrects chan_dahdi to ensure that buffers passed to these ioctls
+ are always fully initialized.
+
+2009-04-01 19:02 +0000 [r185845] David Vossel <dvossel at digium.com>
+
+ * channels/chan_sip.c: Fixes issue with dropped calles due to
+ re-Invite glare and re-Invites never executing after a 491
+ Acknowledgement for 491 responses were never being processed
+ because it didn't match our pending invite's seqno. Since the ACK
+ was never processed, the 491 frame would continue to be
+ retransmitted until eventually the call was dropped due to max
+ retries. Now during a pending invite, if we receive another
+ invite, we send an 491 and hold on to that glare invite's seqno
+ in the "glareinvite" variable for that sip_pvt struct. When ACK's
+ are received, we first check to see if it is in response to our
+ pending invite, if not we check to see if it is in response to a
+ glare invite. In this case, it is in response to the glare invite
+ and must be dealt with or the call is dropped. I've changed the
+ wait time for resending the re-Invite after receving a 491
+ response to comply with RFC 3261. Before this patch the scheduled
+ re-Invite would only change a flag indicating that the re-Invite
+ should be sent out, now it actually sends it out as well. (closes
+ issue #12013) Reported by: alx Review:
+ http://reviewboard.digium.com/r/213/
+
+2009-04-01 13:47 +0000 [r185771] Russell Bryant <russell at digium.com>
+
+ * main/channel.c: Fix a case where DTMF could bypass audiohooks.
+ This change fixes a situation where an audiohook that wants DTMF
+ would not actually get it. This is in the code path where we end
+ DTMF digit length emulation while handling a NULL frame.
+
+2009-03-31 22:00 +0000 [r185468-185599] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_queue.c: Fix crash that would occur if an empty member
+ was specified in queues.conf. (closes issue #14796) Reported by:
+ pida
+
+ * channels/chan_sip.c: Use AST_SCHED_DEL_SPINLOCK instead of
+ manually using the logic.
+
+ * apps/app_voicemail.c: Fix Russian voicemail intro to say the word
+ "messages" properly. (closes issue #14736) Reported by: chappell
+ Patches: voicemail_no_messages.diff uploaded by chappell (license
+ 8)
+
+2009-03-31 16:37 +0000 [r185362] David Brooks <dbrooks at digium.com>
+
+ * channels/chan_gtalk.c: Fix incorrect parsing in chan_gtalk when
+ xmpp contains extra whitespaces To drill into the xmpp to find
+ the capabilities between channels, chan_gtalk calls iks_child()
+ and iks_next(). iks_child() and iks_next() are functions in the
+ iksemel xml parsing library that traverse xml nodes. The bug here
+ is that both iks_child() and iks_next() will return the next
+ iks_struct node *regardless* of type. chan_gtalk expects the next
+ node to be of type IKS_TAG, which in most cases, it is, but in
+ this case (a call being made from the Empathy IM client), there
+ exists iks_struct nodes which are not IKS_TAG data (they are
+ extraneous whitespaces), and chan_gtalk doesn't handle that case,
+ so capabilities don't match, and a call cannot be made.
+ iks_first_tag() and iks_next_tag(), on the other hand, will not
+ return the very next iks_struct, but will check to see if the
+ next iks_struct is of type IKS_TAG. If it isn't, it will be
+ skipped, and the next struct of type IKS_TAG it finds will be
+ returned. This assures that chan_gtalk will find the iks_struct
+ it is looking for. This fix simply changes all calls to
+ iks_child() and iks_next() to become calls to iks_first_tag() and
+ iks_next_tag(), which resolves the capability matching. The
+ following is a payload listing from Empathy, which, due to the
+ extraneous whitespace, will not be parsed correctly by iksemel:
+ <iq from='dbrooksjab at 235-22-24-10/Telepathy'
+ to='astjab at 235-22-24-10/asterisk' type='set' id='542757715704'>
+ <session xmlns='http://www.google.com/session'
+ initiator='dbrooksjab at 235-22-24-10/Telepathy' type='initiate'
+ id='1837267342'> <description
+ xmlns='http://www.google.com/session/phone'> <payload-type
+ clockrate='16000' name='speex' id='96'/> <payload-type
+ clockrate='8000' name='PCMA' id='8'/> <payload-type
+ clockrate='8000' name='PCMU' id='0'/> <payload-type
+ clockrate='90000' name='MPA' id='97'/> <payload-type
+ clockrate='16000' name='SIREN' id='98'/> <payload-type
+ clockrate='8000' name='telephone-event' id='99'/> </description>
+ </session> </iq>
+
+2009-03-31 15:34 +0000 [r185298] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_queue.c: Fix some state_interface stuff that was in
+ trunk but not in the backport to 1.4. Issue #14359 was fixed
+ between the time that I posted the review of the backport of the
+ state interface change for 1.4. This merges the changes from that
+ issue back into 1.4. (closes issue #14359) Reported by:
+ francesco_r
+
+2009-03-31 14:06 +0000 [r185196] Joshua Colp <jcolp at digium.com>
+
+ * main/audiohook.c: Fix crash when moving audiohooks between
+ channels. Handle the scenario where we are called to move
[... 23613 lines stripped ...]
More information about the asterisk-commits
mailing list