[asterisk-commits] rmudgett: branch 1.4 r193613 - /branches/1.4/channels/chan_misdn.c

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Mon May 11 14:09:00 2009
New Revision: 193613

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=193613
Log:
Sent wrong message to clear a call we started if the other end has not responed yet.

In the state MISDN_CALLING (i.e. SETUP was sent but no answer has arrived yet),
it is not allowed to clear the call with RELEASE_COMPLETE.  It must be
cleared with DISCONNECT.  A RELEASE_COMPLETE is only allowed as an answer
to a SETUP.  (See Q.931 ch. 5.3.2, 5.3.2.a, 5.3.2.b)

Patches:
    chan-misdn-ccstate7.patch uploaded by customer.

JIRA ABE-1862

Modified:
    branches/1.4/channels/chan_misdn.c

Modified: branches/1.4/channels/chan_misdn.c
URL: http://svn.asterisk.org/svn-view/asterisk/branches/1.4/channels/chan_misdn.c?view=diff&rev=193613&r1=193612&r2=193613
==============================================================================
--- branches/1.4/channels/chan_misdn.c (original)
+++ branches/1.4/channels/chan_misdn.c Mon May 11 14:09:00 2009
@@ -2610,11 +2610,10 @@
 
 	switch (p->state) {
 	case MISDN_INCOMING_SETUP:
-	case MISDN_CALLING:
 		/* This is the only place in misdn_hangup, where we 
 		 * can call release_chan, else it might create lot's of trouble
 		 * */
-		ast_log(LOG_NOTICE, "release channel, in CALLING/INCOMING_SETUP state.. no other events happened\n");
+		ast_log(LOG_NOTICE, "release channel, in INCOMING_SETUP state.. no other events happened\n");
 		release_chan(bc);
 
 		p->state = MISDN_CLEANING;
@@ -2637,6 +2636,7 @@
 			misdn_lib_send_event( bc, EVENT_DISCONNECT);
 		break;
 
+	case MISDN_CALLING:
 	case MISDN_ALERTING:
 	case MISDN_PROGRESS:
 	case MISDN_PROCEEDING: