[asterisk-commits] russell: trunk r184726 - in /trunk: apps/app_minivm.c main/manager.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Mar 27 13:04:46 CDT 2009


Author: russell
Date: Fri Mar 27 13:04:43 2009
New Revision: 184726

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=184726
Log:
Use ast_random() instead of rand() to ensure we use the best RNG available.

Modified:
    trunk/apps/app_minivm.c
    trunk/main/manager.c

Modified: trunk/apps/app_minivm.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/apps/app_minivm.c?view=diff&rev=184726&r1=184725&r2=184726
==============================================================================
--- trunk/apps/app_minivm.c (original)
+++ trunk/apps/app_minivm.c Fri Mar 27 13:04:43 2009
@@ -1177,7 +1177,7 @@
 	} 
 	ast_debug(4, "Fromstring now: %s\n", ast_strlen_zero(passdata) ? "-default-" : passdata);
 
-	fprintf(p, "Message-ID: <Asterisk-%d-%s-%d-%s>\n", (unsigned int)rand(), vmu->username, (int)getpid(), who);
+	fprintf(p, "Message-ID: <Asterisk-%d-%s-%d-%s>\n", (unsigned int)ast_random(), vmu->username, (int)getpid(), who);
 	len_passdata = strlen(vmu->fullname) * 2 + 3;
 	passdata2 = alloca(len_passdata);
 	if (!ast_strlen_zero(vmu->email))
@@ -1210,7 +1210,7 @@
 	fprintf(p, "MIME-Version: 1.0\n");
 
 	/* Something unique. */
-	snprintf(bound, sizeof(bound), "voicemail_%s%d%d", vmu->username, (int)getpid(), (unsigned int)rand());
+	snprintf(bound, sizeof(bound), "voicemail_%s%d%d", vmu->username, (int)getpid(), (unsigned int)ast_random());
 
 	fprintf(p, "Content-Type: multipart/mixed; boundary=\"%s\"\n\n\n", bound);
 

Modified: trunk/main/manager.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/main/manager.c?view=diff&rev=184726&r1=184725&r2=184726
==============================================================================
--- trunk/main/manager.c (original)
+++ trunk/main/manager.c Fri Mar 27 13:04:43 2009
@@ -3803,7 +3803,7 @@
 		 * properties of the rand() function (and the constantcy of s), that
 		 * won't happen twice in a row.
 		 */
-		while ((session->managerid = rand() ^ (unsigned long) session) == 0);
+		while ((session->managerid = ast_random() ^ (unsigned long) session) == 0);
 		session->last_ev = grab_last();
 		AST_LIST_HEAD_INIT_NOLOCK(&session->datastores);
 		AST_LIST_LOCK(&sessions);




More information about the asterisk-commits mailing list