[asterisk-commits] mmichelson: branch 1.6.2 r184082 - in /branches/1.6.2: ./ apps/app_senddtmf.c

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Tue Mar 24 17:42:26 2009
New Revision: 184082

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=184082
Log:
Merged revisions 184079 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r184079 | mmichelson | 2009-03-24 17:40:39 -0500 (Tue, 24 Mar 2009) | 15 lines
  
  Merged revisions 184078 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r184078 | mmichelson | 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) | 9 lines
    
    Change NULL pointer check to be ast_strlen_zero.
    
    The 'digit' variable is guaranteed to be non-NULL, so the if
    statement could never evaluate true. Changing to ast_strlen_zero
    makes the logic correct.
    
    This was found while reviewing ast_channel_ao2 code review.
  ........
................

Modified:
    branches/1.6.2/   (props changed)
    branches/1.6.2/apps/app_senddtmf.c

Propchange: branches/1.6.2/
------------------------------------------------------------------------------
--- trunk-merged (original)
+++ trunk-merged Tue Mar 24 17:42:26 2009
@@ -1,1 +1,1 @@
-/trunk:1-182359,182408,182450,182525,182530,182553,182722,182847,183028,183057,183108,183117,183242,183244,183321,183511,183560,183701,183766,183865,183914,184037,184043
+/trunk:1-182359,182408,182450,182525,182530,182553,182722,182847,183028,183057,183108,183117,183242,183244,183321,183511,183560,183701,183766,183865,183914,184037,184043,184079

Modified: branches/1.6.2/apps/app_senddtmf.c
URL: http://svn.digium.com/svn-view/asterisk/branches/1.6.2/apps/app_senddtmf.c?view=diff&rev=184082&r1=184081&r2=184082
==============================================================================
--- branches/1.6.2/apps/app_senddtmf.c (original)
+++ branches/1.6.2/apps/app_senddtmf.c Tue Mar 24 17:42:26 2009
@@ -106,7 +106,7 @@
 		astman_send_error(s, m, "Channel not specified");
 		return 0;
 	}
-	if (!digit) {
+	if (ast_strlen_zero(digit)) {
 		astman_send_error(s, m, "No digit specified");
 		ast_channel_unlock(chan);
 		return 0;