[asterisk-commits] kpfleming: trunk r208548 - in /trunk: channels/ include/asterisk/ main/

[SVN commits to the Asterisk project]

Author: kpfleming
Date: Fri Jul 24 10:02:53 2009
New Revision: 208548

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=208548
Log:
Resolve a T.38 negotiation issue left over from the udptl-updates merge.

The udptl-updates branch that was merged yesterday failed to properly send back
T.38 SDP responses with the correct error correction mode, if the incoming SDP
from the other end caused us to change error correction modes. This patch
corrects that situation.


Modified:
    trunk/channels/chan_sip.c
    trunk/include/asterisk/udptl.h
    trunk/main/udptl.c

Modified: trunk/channels/chan_sip.c
URL: http://svn.asterisk.org/svn-view/asterisk/trunk/channels/chan_sip.c?view=diff&rev=208548&r1=208547&r2=208548
==============================================================================
--- trunk/channels/chan_sip.c (original)
+++ trunk/channels/chan_sip.c Fri Jul 24 10:02:53 2009
@@ -10087,13 +10087,13 @@
 			break;
 		}
 		ast_str_append(&a_modem, 0, "a=T38FaxMaxDatagram:%d\r\n", ast_udptl_get_local_max_datagram(p->udptl));
-		switch (ast_test_flag(&p->flags[1],  SIP_PAGE2_T38SUPPORT)) {
-		case SIP_PAGE2_T38SUPPORT_UDPTL:
+		switch (ast_udptl_get_error_correction_scheme(p->udptl)) {
+		case UDPTL_ERROR_CORRECTION_NONE:
 			break;
-		case SIP_PAGE2_T38SUPPORT_UDPTL_FEC:
+		case UDPTL_ERROR_CORRECTION_FEC:
 			ast_str_append(&a_modem, 0, "a=T38FaxUdpEC:t38UDPFEC\r\n");
 			break;
-		case SIP_PAGE2_T38SUPPORT_UDPTL_REDUNDANCY:
+		case UDPTL_ERROR_CORRECTION_REDUNDANCY:
 			ast_str_append(&a_modem, 0, "a=T38FaxUdpEC:t38UDPRedundancy\r\n");
 			break;
 		}

Modified: trunk/include/asterisk/udptl.h
URL: http://svn.asterisk.org/svn-view/asterisk/trunk/include/asterisk/udptl.h?view=diff&rev=208548&r1=208547&r2=208548
==============================================================================
--- trunk/include/asterisk/udptl.h (original)
+++ trunk/include/asterisk/udptl.h Fri Jul 24 10:02:53 2009
@@ -87,7 +87,7 @@
 void ast_udptl_set_udptlmap_type(struct ast_udptl *udptl, unsigned int pt,
 				 char *mimeType, char *mimeSubtype);
 
-int ast_udptl_get_error_correction_scheme(const struct ast_udptl *udptl);
+enum ast_t38_ec_modes ast_udptl_get_error_correction_scheme(const struct ast_udptl *udptl);
 
 void ast_udptl_set_error_correction_scheme(struct ast_udptl *udptl, enum ast_t38_ec_modes ec);
 

Modified: trunk/main/udptl.c
URL: http://svn.asterisk.org/svn-view/asterisk/trunk/main/udptl.c?view=diff&rev=208548&r1=208547&r2=208548
==============================================================================
--- trunk/main/udptl.c (original)
+++ trunk/main/udptl.c Fri Jul 24 10:02:53 2009
@@ -769,7 +769,7 @@
 	udptl->far_max_ifp = new_max * 0.75;
 }
 
-int ast_udptl_get_error_correction_scheme(const struct ast_udptl *udptl)
+enum ast_t38_ec_modes ast_udptl_get_error_correction_scheme(const struct ast_udptl *udptl)
 {
 	if (udptl)
 		return udptl->error_correction_scheme;