[asterisk-commits] tilghman: trunk r204986 - /trunk/addons/res_config_mysql.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Mon Jul  6 16:37:39 2009
New Revision: 204986

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=204986
Log:
Merged revisions 981 via svnmerge from 
https://origsvn.digium.com/svn/asterisk-addons/branches/1.4

........
  r981 | tilghman | 2009-07-06 16:30:13 -0500 (Mon, 06 Jul 2009) | 7 lines
  
  Don't reset reconnect time, unless a reconnect really occurred.
  (closes issue #15375)
   Reported by: kowalma
   Patches: 
         20090628__issue15375.diff.txt uploaded by tilghman (license 14)
   Tested by: kowalma, jacco
........

Modified:
    trunk/addons/res_config_mysql.c

Modified: trunk/addons/res_config_mysql.c
URL: http://svn.asterisk.org/svn-view/asterisk/trunk/addons/res_config_mysql.c?view=diff&rev=204986&r1=204985&r2=204986
==============================================================================
--- trunk/addons/res_config_mysql.c (original)
+++ trunk/addons/res_config_mysql.c Mon Jul  6 16:37:39 2009
@@ -1563,6 +1563,7 @@
 			ast_log(LOG_ERROR, "MySQL RealTime: Failed to connect database server %s on %s (err %d). Check debug for more info.\n", conn->name, !ast_strlen_zero(conn->host) ? conn->host : conn->sock, mysql_errno(&conn->handle));
 			ast_debug(1, "MySQL RealTime: Cannot Connect (%d): %s\n", mysql_errno(&conn->handle), mysql_error(&conn->handle));
 			conn->connected = 0;
+			conn->connect_time = 0;
 			return 0;
 		}
 	} else {
@@ -1570,13 +1571,16 @@
 		 * So the postman pings twice. */
 		if (mysql_ping(&conn->handle) != 0 && (usleep(1) + 2 > 0) && mysql_ping(&conn->handle) != 0) {
 			conn->connected = 0;
+			conn->connect_time = 0;
 			ast_log(LOG_ERROR, "MySQL RealTime: Ping failed (%d).  Trying an explicit reconnect.\n", mysql_errno(&conn->handle));
 			ast_debug(1, "MySQL RealTime: Server Error (%d): %s\n", mysql_errno(&conn->handle), mysql_error(&conn->handle));
 			goto reconnect_tryagain;
 		}
 
-		conn->connected = 1;
-		conn->connect_time = time(NULL);
+		if (!conn->connected) {
+			conn->connected = 1;
+			conn->connect_time = time(NULL);
+		}
 
 		if (mysql_select_db(&conn->handle, conn->name) != 0) {
 			ast_log(LOG_WARNING, "MySQL RealTime: Unable to select database: %s. Still Connected (%u) - %s.\n", conn->name, mysql_errno(&conn->handle), mysql_error(&conn->handle));
@@ -1660,7 +1664,7 @@
 			AST_LIST_TRAVERSE(&cur->columns, col, list) {
 				ast_cli(a->fd, "%-20.20s %-20.20s %3d\n", col->name, col->type, col->len);
 			}
-			ast_mutex_unlock(&cur->lock);
+			release_table(cur);
 		} else {
 			ast_cli(a->fd, "No such table '%s'\n", a->argv[3]);
 		}