[asterisk-commits] murf: branch 1.4 r178956 - in /branches/1.4: configs/ res/

[SVN commits to the Asterisk project]

Author: murf
Date: Thu Feb 26 15:27:32 2009
New Revision: 178956

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=178956
Log:
This change moves the default feature digit timeout to 1000 ms from the previous default of 500.

As per bug 14515, a dev discussion arrived at a "mediated concensus" 
of a default feature digit timeout of 1.0 sec. Some voted for 1300;
ctooley thought 1500 for distracted phone users in phone booths; 
kpfleming put his foot down at 1.0 sec. 

Users who found the previous default max delay of 250 msec perfect,
are welcome to override the new default. Notice that I said that
250 msec was the default; wait a minute, you might say, the config
file said it was 500 msec!; well, because of the bug fix for 14515,
we found that 500 msec was actually enforcing a max of 250. The bug
fix would restore 500 msec, but we felt even that was a bit tight
for most users... 2000 msec was pushed earlier by mmichelson, so
that reduces to 1000 msec after the bug fix. Enjoy!



Modified:
    branches/1.4/configs/features.conf.sample
    branches/1.4/res/res_features.c

Modified: branches/1.4/configs/features.conf.sample
URL: http://svn.digium.com/svn-view/asterisk/branches/1.4/configs/features.conf.sample?view=diff&rev=178956&r1=178955&r2=178956
==============================================================================
--- branches/1.4/configs/features.conf.sample (original)
+++ branches/1.4/configs/features.conf.sample Thu Feb 26 15:27:32 2009
@@ -35,9 +35,9 @@
 ;xfersound = beep		; to indicate an attended transfer is complete
 ;xferfailsound = beeperr	; to indicate a failed transfer
 ;pickupexten = *8		; Configure the pickup extension. (default is *8)
-;featuredigittimeout = 500	; Max time (ms) between digits for 
-				; feature activation  (default is 500 ms)
-;atxfernoanswertimeout = 15	; Timeout for answer on attended transfer default is 15 seconds.
+;featuredigittimeout = 1000 ; Max time (ms) between digits for 
+                            ; feature activation  (default is 1000 ms)
+;atxfernoanswertimeout = 15 ; Timeout for answer on attended transfer default is 15 seconds.
 
 ; Note that the DTMF features listed below only work when two channels have answered and are bridged together.
 ; They can not be used while the remote party is ringing or in progress. If you require this feature you can use

Modified: branches/1.4/res/res_features.c
URL: http://svn.digium.com/svn-view/asterisk/branches/1.4/res/res_features.c?view=diff&rev=178956&r1=178955&r2=178956
==============================================================================
--- branches/1.4/res/res_features.c (original)
+++ branches/1.4/res/res_features.c Thu Feb 26 15:27:32 2009
@@ -66,7 +66,7 @@
 
 #define DEFAULT_PARK_TIME 45000
 #define DEFAULT_TRANSFER_DIGIT_TIMEOUT 3000
-#define DEFAULT_FEATURE_DIGIT_TIMEOUT 500
+#define DEFAULT_FEATURE_DIGIT_TIMEOUT 1000
 #define DEFAULT_NOANSWER_TIMEOUT_ATTENDED_TRANSFER 15000
 
 #define AST_MAX_WATCHERS 256