[asterisk-commits] tilghman: trunk r178342 - in /trunk: main/asterisk.c utils/astcanary.c

[SVN commits to the Asterisk project]

Author: tilghman
Date: Tue Feb 24 14:06:48 2009
New Revision: 178342

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=178342
Log:
Use a SIGPIPE to kill the process, instead of depending upon the astcanary process being inherited by init.

Modified:
    trunk/main/asterisk.c
    trunk/utils/astcanary.c

Modified: trunk/main/asterisk.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/main/asterisk.c?view=diff&rev=178342&r1=178341&r2=178342
==============================================================================
--- trunk/main/asterisk.c (original)
+++ trunk/main/asterisk.c Tue Feb 24 14:06:48 2009
@@ -274,6 +274,7 @@
 static pthread_t consolethread = AST_PTHREADT_NULL;
 static int canary_pid = 0;
 static char canary_filename[128];
+static int canary_pipe = -1;
 
 static char randompool[256];
 
@@ -3298,7 +3299,16 @@
 	if (isroot) {
 		ast_set_priority(ast_opt_high_priority);
 		if (ast_opt_high_priority) {
+			int cpipe[2];
+
+			/* PIPE signal ensures that astcanary dies when Asterisk dies */
+			pipe(cpipe);
+			canary_pipe = cpipe[0];
+
 			snprintf(canary_filename, sizeof(canary_filename), "%s/alt.asterisk.canary.tweet.tweet.tweet", ast_config_AST_RUN_DIR);
+
+			/* Don't let the canary child kill Asterisk, if it dies immediately */
+			signal(SIGPIPE, SIG_IGN);
 
 			canary_pid = fork();
 			if (canary_pid == 0) {
@@ -3307,9 +3317,14 @@
 
 				/* Reset signal handler */
 				signal(SIGCHLD, SIG_DFL);
-
-				for (fd = 0; fd < 100; fd++)
+				signal(SIGPIPE, SIG_DFL);
+
+				dup2(cpipe[1], 100);
+				close(cpipe[1]);
+
+				for (fd = 0; fd < 100; fd++) {
 					close(fd);
+				}
 
 				execlp("astcanary", "astcanary", canary_filename, (char *)NULL);
 
@@ -3324,6 +3339,7 @@
 				_exit(1);
 			} else if (canary_pid > 0) {
 				pthread_t dont_care;
+				close(cpipe[1]);
 				ast_pthread_create_detached(&dont_care, NULL, canary_thread, NULL);
 			}
 

Modified: trunk/utils/astcanary.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/utils/astcanary.c?view=diff&rev=178342&r1=178341&r2=178342
==============================================================================
--- trunk/utils/astcanary.c (original)
+++ trunk/utils/astcanary.c Tue Feb 24 14:06:48 2009
@@ -89,7 +89,7 @@
 	int fd;
 	/* Run at normal priority */
 	setpriority(PRIO_PROCESS, 0, 0);
-	for (; getppid() != 1;) {
+	for (;;) {
 		/* Update the modification times (checked from Asterisk) */
 		if (utime(argv[1], NULL)) {
 			/* Recreate the file if it doesn't exist */
@@ -108,7 +108,7 @@
 		sleep(5);
 	}
 
-	/* Reached if asterisk (our parent process) dies - its chldren are inherited by the init process (pid is 1). */
+	/* Never reached */
 	return 0;
 }