[asterisk-commits] russell: branch russell/event_core r177979 - /team/russell/event_core/main/

[SVN commits to the Asterisk project]

Author: russell
Date: Sat Feb 21 19:55:02 2009
New Revision: 177979

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=177979
Log:
Identify the target for improvement ...

Modified:
    team/russell/event_core/main/event.c

Modified: team/russell/event_core/main/event.c
URL: http://svn.digium.com/svn-view/asterisk/team/russell/event_core/main/event.c?view=diff&rev=177979&r1=177978&r2=177979
==============================================================================
--- team/russell/event_core/main/event.c (original)
+++ team/russell/event_core/main/event.c Sat Feb 21 19:55:02 2009
@@ -107,10 +107,17 @@
  * The event subscribers are indexed by which event they are subscribed to */
 static AST_RWDLLIST_HEAD(ast_event_sub_list, ast_event_sub) ast_event_subs[AST_EVENT_TOTAL];
 
-/*! \brief Cached events
+/*! 
+ * \brief Cached events
+ *
  * The event cache is indexed on the event type.  The purpose of this is 
  * for events that express some sort of state.  So, when someone first
- * needs to know this state, it can get the last known state from the cache. */
+ * needs to know this state, it can get the last known state from the cache.
+ *
+ * \todo Improve the data structure usage here.  This was fine at first, but now that
+ * device state is part of this, as well, it's really bad.  The device state cache is
+ * too big, and gets hit too often for this type of storage.
+ */
 static AST_RWLIST_HEAD(ast_event_ref_list, ast_event_ref) ast_event_cache[AST_EVENT_TOTAL];
 
 /*!