[asterisk-commits] tilghman: trunk r177664 - in /trunk: apps/ include/asterisk/ main/

[SVN commits to the Asterisk project]

Author: tilghman
Date: Fri Feb 20 11:29:51 2009
New Revision: 177664

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=177664
Log:
Allow semicolons to be escaped, when passing arguments to the System command.
(closes issue #14231)
 Reported by: jcovert
 Patches: 
       20090113__bug14231__2.diff.txt uploaded by Corydon76 (license 14)
       corrected_20090113__bug14231__2.diff.txt uploaded by jcovert (license 551)
 Tested by: jcovert

Modified:
    trunk/apps/app_system.c
    trunk/include/asterisk/app.h
    trunk/main/app.c

Modified: trunk/apps/app_system.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/apps/app_system.c?view=diff&rev=177664&r1=177663&r2=177664
==============================================================================
--- trunk/apps/app_system.c (original)
+++ trunk/apps/app_system.c Fri Feb 20 11:29:51 2009
@@ -33,6 +33,8 @@
 #include "asterisk/module.h"
 #include "asterisk/app.h"
 #include "asterisk/channel.h"	/* autoservice */
+#include "asterisk/strings.h"
+#include "asterisk/threadstorage.h"
 
 /*** DOCUMENTATION
 	<application name="System" language="en_US">
@@ -90,6 +92,8 @@
 
  ***/
 
+AST_THREADSTORAGE(buf_buf);
+
 static char *app = "System";
 
 static char *app2 = "TrySystem";
@@ -99,6 +103,7 @@
 static int system_exec_helper(struct ast_channel *chan, void *data, int failmode)
 {
 	int res = 0;
+	struct ast_str *buf = ast_str_thread_get(&buf_buf, 16);
 	
 	if (ast_strlen_zero(data)) {
 		ast_log(LOG_WARNING, "System requires an argument(command)\n");
@@ -109,7 +114,9 @@
 	ast_autoservice_start(chan);
 
 	/* Do our thing here */
-	res = ast_safe_system((char *)data);
+	ast_str_get_encoded_str(&buf, 0, (char *) data);
+	res = ast_safe_system(ast_str_buffer(buf));
+
 	if ((res < 0) && (errno != ECHILD)) {
 		ast_log(LOG_WARNING, "Unable to execute '%s'\n", (char *)data);
 		pbx_builtin_setvar_helper(chan, chanvar, "FAILURE");

Modified: trunk/include/asterisk/app.h
URL: http://svn.digium.com/svn-view/asterisk/trunk/include/asterisk/app.h?view=diff&rev=177664&r1=177663&r2=177664
==============================================================================
--- trunk/include/asterisk/app.h (original)
+++ trunk/include/asterisk/app.h Fri Feb 20 11:29:51 2009
@@ -498,6 +498,9 @@
 /*! \brief Decode a stream of encoded control or extended ASCII characters */
 char *ast_get_encoded_str(const char *stream, char *result, size_t result_len);
 
+/*! \brief Decode a stream of encoded control or extended ASCII characters */
+int ast_str_get_encoded_str(struct ast_str **str, int maxlen, const char *stream);
+
 /*! \brief Common routine for child processes, to close all fds prior to exec(2) */
 void ast_close_fds_above_n(int n);
 

Modified: trunk/main/app.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/main/app.c?view=diff&rev=177664&r1=177663&r2=177664
==============================================================================
--- trunk/main/app.c (original)
+++ trunk/main/app.c Fri Feb 20 11:29:51 2009
@@ -1846,6 +1846,33 @@
 	return result;
 }
 
+int ast_str_get_encoded_str(struct ast_str **str, int maxlen, const char *stream)
+{
+	char next, *buf;
+	size_t offset = 0;
+	size_t consumed;
+
+	if (strchr(stream, '\\')) {
+		while (!ast_get_encoded_char(stream, &next, &consumed)) {
+			if (offset + 2 > ast_str_size(*str) && maxlen > -1) {
+				ast_str_make_space(str, maxlen > 0 ? maxlen : (ast_str_size(*str) + 48) * 2 - 48);
+			}
+			if (offset + 2 > ast_str_size(*str)) {
+				break;
+			}
+			buf = ast_str_buffer(*str);
+			buf[offset++] = next;
+			stream += consumed;
+		}
+		buf = ast_str_buffer(*str);
+		buf[offset++] = '\0';
+		ast_str_update(*str);
+	} else {
+		ast_str_set(str, maxlen, "%s", stream);
+	}
+	return 0;
+}
+
 void ast_close_fds_above_n(int n)
 {
 #ifdef HAVE_CLOSEFROM