[asterisk-commits] mmichelson: trunk r175591 - in /trunk: ./ apps/app_voicemail.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Feb 13 13:49:38 CST 2009


Author: mmichelson
Date: Fri Feb 13 13:49:38 2009
New Revision: 175591

URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=175591
Log:
Merged revisions 175590 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r175590 | mmichelson | 2009-02-13 13:47:48 -0600 (Fri, 13 Feb 2009) | 16 lines
  
  Fix a potential crash situation when using IMAP voicemail
  
  If calling into VoiceMailMain when using IMAP storage, it was
  possible to crash Asterisk by hanging up the phone when prompted
  for a voicemail mailbox. This patch fixes the issue.
  
  While it may appear that this patch is superficial, it allows code
  execution to continue to the failure case just below the IMAP_STORAGE
  code block where this patch has been applied
  
  (closes issue #14473)
  Reported by: dwpaul
  Patches:
        voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689)
........

Modified:
    trunk/   (props changed)
    trunk/apps/app_voicemail.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/apps/app_voicemail.c
URL: http://svn.digium.com/svn-view/asterisk/trunk/apps/app_voicemail.c?view=diff&rev=175591&r1=175590&r2=175591
==============================================================================
--- trunk/apps/app_voicemail.c (original)
+++ trunk/apps/app_voicemail.c Fri Feb 13 13:49:38 2009
@@ -8894,7 +8894,8 @@
 #ifdef IMAP_STORAGE
 	vms.interactive = 1;
 	vms.updated = 1;
-	ast_copy_string(vms.context, vmu->context, sizeof(vms.context));
+	if (vmu)
+		ast_copy_string(vms.context, vmu->context, sizeof(vms.context));
 	vmstate_insert(&vms);
 	init_vm_state(&vms);
 #endif




More information about the asterisk-commits mailing list