[asterisk-commits] dvossel: branch 1.4 r233471 - /branches/1.4/channels/chan_sip.c

[SVN commits to the Asterisk project]

Author: dvossel
Date: Mon Dec  7 12:07:38 2009
New Revision: 233471

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=233471
Log:
fixes missing Contact header angle brackets

(closes issue #16298)
Reported by: mgernoth
Patches:
      reg_parse_issue_1.4.diff uploaded by dvossel (license 671)
Tested by: dvossel


Modified:
    branches/1.4/channels/chan_sip.c

Modified: branches/1.4/channels/chan_sip.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.4/channels/chan_sip.c?view=diff&rev=233471&r1=233470&r2=233471
==============================================================================
--- branches/1.4/channels/chan_sip.c (original)
+++ branches/1.4/channels/chan_sip.c Mon Dec  7 12:07:38 2009
@@ -6411,7 +6411,9 @@
 		add_header(resp, "Expires", tmp);
 		if (p->expiry) {	/* Only add contact if we have an expiry time */
 			char contact[SIPBUFSIZE];
-			snprintf(contact, sizeof(contact), "%s;expires=%d", (p->method == SIP_SUBSCRIBE ? p->our_contact : p->fullcontact), p->expiry);
+			const char *contact_uri = p->method == SIP_SUBSCRIBE ? p->our_contact : p->fullcontact;
+			char *brackets = strchr(contact_uri, '<');
+			snprintf(contact, sizeof(contact), "%s%s%s;expires=%d", brackets ? "" : "<", contact_uri, brackets ? "" : ">", p->expiry);
 			add_header(resp, "Contact", contact);	/* Not when we unregister */
 		}
 	} else if (!ast_strlen_zero(p->our_contact) && resp_needs_contact(msg, p->method)) {